Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grammar: replace all occurrences of "the the" with "the" #112546

Merged
merged 1 commit into from Oct 19, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Sep 17, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:

There seems to be multiple occurrences of "the the" in different places. This seems like a grammatical mistake. Therefore "the the" is replaced with "the".

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 17, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2022
@SergeyKanzhelev
Copy link
Member

This is not complete. Search for comments with line breaks. Somethis like this: the(\s)*\n(\s)*\/\/(\s)*the:

11 results - 11 files

pkg/controller/endpoint/endpoints_controller.go:
  237  
  238: 			// if the family was incorrectly identified then this will be corrected once the
  239: 			// the upgrade is completed (controller connects to api-server that correctly defaults services)
  240  			if utilnet.IsIPv6String(pod.Status.PodIP) {

pkg/kubelet/cm/topologymanager/policy.go:
  318  
  319: 		// Loop through all hints for provider 'i', and recurse to build the
  320: 		// the permutation of this hint with all hints from providers 'i++'.
  321  		for j := range allProviderHints[i] {

pkg/volume/volume.go:
  287  type BulkVolumeVerifier interface {
  288: 	// BulkVerifyVolumes checks whether the list of volumes still attached to the
  289: 	// the clusters in the node. It returns a map which maps from the volume spec to the checking result.
  290  	// If an error occurs during check - error should be returned and volume on nodes

staging/src/k8s.io/apiextensions-apiserver/third_party/forked/celopenapi/model/schemas.go:
  54  
  55: // SchemaDeclType converts the structural schema to a CEL declaration, or returns nil if the
  56: // the structural schema should not be exposed in CEL expressions.
  57  // Set isResourceRoot to true for the root of a custom resource or embedded resource.

staging/src/k8s.io/apiserver/pkg/admission/plugins.go:
  87  
  88: // getPlugin creates an instance of the named plugin.  It returns `false` if the
  89: // the name is not known. The error is returned only when the named provider was
  90  // known but failed to initialize.  The config parameter specifies the io.Reader

staging/src/k8s.io/apiserver/pkg/storage/names/generate.go:
  27  type NameGenerator interface {
  28: 	// GenerateName generates a valid name from the base name, adding a random suffix to the
  29: 	// the base. If base is valid, the returned name must also be valid. The generator is
  30  	// responsible for knowing the maximum valid name length.

staging/src/k8s.io/kubectl/pkg/cmd/get/sorter.go:
  337  // OriginalPosition returns the starting (original) position of a particular index.
  338: // e.g. If OriginalPosition(0) returns 5 than the
  339: // the item currently at position 0 was at position 5 in the original unsorted array.
  340  func (r *RuntimeSort) OriginalPosition(ix int) int {

test/e2e/framework/log.go:
  81  	stack := bytes.Split(fullStackTrace, []byte("\n"))
  82: 	// Ensure that the even entries are the method names and the
  83: 	// the odd entries the source code information.
  84  	if len(stack) > 0 && bytes.HasPrefix(stack[0], []byte("goroutine ")) {

test/e2e/network/network_tiers.go:
  160  	// If the IP has been used by previous test, sometimes we get the lingering
  161: 	// 404 errors even after the LB is long gone. Tolerate and retry until the
  162: 	// the new LB is fully established.
  163  	e2eservice.TestReachableHTTPWithRetriableErrorCodes(ingressIP, svcPort, []int{http.StatusNotFound}, checkTimeout)

test/e2e/network/service.go:
  318  
  319: // verifyServeHostnameServiceUp wgets the given serviceIP:servicePort from the
  320: // the host exec pod of host network type and from the exec pod of container network type.
  321  // Each pod in the service is expected to echo its name. These names are compared with the

test/e2e/windows/security_context.go:
  135  		// It is sufficient to show that the pod comes up here. Since we're stripping the SELinux and other linux
  136: 		// security contexts in apiserver and not updating the pod object in the apiserver, we cannot validate the
  137: 		// the pod object to not have those security contexts. However the pod coming to running state is a sufficient
  138  		// enough condition for us to validate since prior to https://github.com/kubernetes/kubernetes/pull/93475

@SergeyKanzhelev
Copy link
Member

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 19, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/apiserver area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubectl and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2022
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 7, 2022
@oscr
Copy link
Contributor Author

oscr commented Oct 7, 2022

/retest

@SergeyKanzhelev SergeyKanzhelev moved this from PRs - Needs Approver to Done in SIG Node CI/Test Board Oct 7, 2022
@SergeyKanzhelev
Copy link
Member

this is non-controversial.

@dims do you have enough powers to approve?

SIG Node CI/Test Board automation moved this from Done to PRs - Needs Approver Oct 8, 2022
@dims
Copy link
Member

dims commented Oct 8, 2022

/approve

@SergeyKanzhelev SergeyKanzhelev moved this from PRs - Needs Approver to Archive-it in SIG Node CI/Test Board Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2022
@dims
Copy link
Member

dims commented Oct 15, 2022

/assign @puerco @palnabarun

@csantanapr
Copy link
Member

csantanapr commented Oct 19, 2022

Thank you @oscr 👍
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, dims, mrunalp, oscr, SergeyKanzhelev, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@csantanapr
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2022
@oscr
Copy link
Contributor Author

oscr commented Oct 19, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

@oscr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-integration e4f776f link unknown /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member

dims commented Oct 19, 2022

/retest

unrelated failure:



```test-cmd: run_kubectl_apply_tests expand_less | 48s```

@oscr
Copy link
Contributor Author

oscr commented Oct 19, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit bf14677 into kubernetes:master Oct 19, 2022
SIG Node CI/Test Board automation moved this from Archive-it to Done Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 19, 2022
@oscr oscr deleted the the-the branch October 19, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Development

Successfully merging this pull request may close these issues.

None yet

9 participants