Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that kubectl convert does not pick the right api version #112700

Merged
merged 1 commit into from Oct 14, 2022

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 23, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix the bug that kubectl convert does not pick the right api version

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1298

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubectl: fixed a bug where `kubectl convert` did not pick the right API version

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 23, 2022
@aojea
Copy link
Member

aojea commented Sep 23, 2022

/assign @deads2k @soltysh

@SataQiu
Copy link
Member Author

SataQiu commented Sep 24, 2022

/test pull-kubernetes-e2e-gce-ubuntu-containerd

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed ensures the extensions API is considered the last when decoding and reading the default option, you can still explicitly request it with --output-version=extensions/v1beta1

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@soltysh
Copy link
Contributor

soltysh commented Oct 14, 2022

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0207f7a into kubernetes:master Oct 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 14, 2022
@sftim
Copy link
Contributor

sftim commented Oct 16, 2022

Hope this is OK:

/release-note-edit

kubectl: fixed a bug where `kubectl convert` did not pick the right API version

@k8s-ci-robot
Copy link
Contributor

@sftim: /release-note-edit must be used with a release note block.

In response to this:

Hope this is OK:

/release-note-edit

kubectl: fixed a bug where `kubectl convert` did not pick the right API version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Oct 16, 2022

/release-note-edit

kubectl: fixed a bug where `kubectl convert` did not pick the right API version

@k8s-ci-robot
Copy link
Contributor

@sftim: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

kubectl: fixed a bug where `kubectl convert` did not pick the right API version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Oct 16, 2022

OK, not sure about the command but that's the change I recommend.

@liggitt
Copy link
Member

liggitt commented Oct 18, 2022

Thanks for the PR... one thing to note is that relying on import order is fragile… this preferred order should be set explicitly (and a unit test added to cover this scenario so it doesn't regress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl convert doesnt pick right API version for conversion
7 participants