New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire up feature-gate for component slis #112884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
do-not-merge/needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
area/apiserver
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
and removed
do-not-merge/needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
labels
Oct 5, 2022
logicalhan
force-pushed
the
slis
branch
4 times, most recently
from
October 5, 2022 20:56
c0fbe30
to
96b6aa6
Compare
/retest |
/retest |
logicalhan
force-pushed
the
slis
branch
3 times, most recently
from
October 6, 2022 15:16
c89eda1
to
3a01334
Compare
/assign @lavalamp |
/triage accepted |
k8s-ci-robot
added
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
and removed
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Oct 6, 2022
lavalamp
reviewed
Oct 6, 2022
Change-Id: Iba6ffbcac9dba4f4be3023ada6ac31691c1ae17b
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Oct 6, 2022
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Puts
/metrics/slis
behind a feature gate.Special notes for your reviewer:
Does this PR introduce a user-facing change?