Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up metrics/slis for kube-controller-manager #112958

Closed
logicalhan opened this issue Oct 10, 2022 · 4 comments · Fixed by #112978
Closed

Wire up metrics/slis for kube-controller-manager #112958

logicalhan opened this issue Oct 10, 2022 · 4 comments · Fixed by #112978
Assignees
@richabanker
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation.

Comments

@logicalhan
Copy link
Member

What would you like to be added?

As per, https://kep.k8s.io/3466, wire up metrics/slis for KCM

Why is this needed?

https://kep.k8s.io/3466
@logicalhan logicalhan added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 10, 2022
@logicalhan
Copy link
Member Author

/sig instrumentation

@k8s-ci-robot
Copy link
Contributor

@logicalhan: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 10, 2022
@richabanker
Copy link
Contributor

/assign

@logicalhan
Copy link
Member Author

/sig instrumentation

@logicalhan logicalhan mentioned this issue Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richabanker richabanker

Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add 'metrics/slis' to kcm health checks logicalhan/kubernetes
3 participants
@logicalhan @k8s-ci-robot @richabanker