New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restart claim sync when PVC is updated #113137
restart claim sync when PVC is updated #113137
Conversation
We should not rely on syncUnboundClaim() to do nothing after it updates PVC with a default storage class until next re-sync but instead restart the sync explicitly to make sure we hit isDelayBindingMode() and findBestMatchForClaim() immediately right after the PVC update.
@RomanBednar: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @liggitt |
/sig storage |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We should not rely on syncUnboundClaim() to do nothing after it updates PVC with a default storage class until next re-sync but instead restart the sync explicitly to make sure we hit isDelayBindingMode() and findBestMatchForClaim() immediately right after the PVC update.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is based on suggestion in this comment: https://github.com/kubernetes/kubernetes/pull/111467/files#r995755779
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: