New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Version Bump in Manifest for Node Perf Test tf-wide-deep #113282
Conversation
…oved the data download from the tf-wide-deep pod spec command
Hi @xmcqueen. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/sig node
/lgtm
/approve
/sig testing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, SergeyKanzhelev, xmcqueen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@SergeyKanzhelev Sorry, but I need a second |
/priority important-soon |
@xmcqueen: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Bumped version of tf-wide-deep image to 1.3 in test manifest, and removed the data download from the tf-wide-deep pod spec command, since it is now done at image-build time.
The image has been promoted.
The promoted image has been tested via local runs of this kind:
make test-e2e-node FOCUS='Node Performance Testing \[Serial\] \[Slow\] Run node performance testing with pre-defined workloads TensorFlow workload' SKIP="QQQQQ"
What type of PR is this?
/kind failing-test
/kind flake
What this PR does / why we need it:
This PR is expected to fix the failing test here as was the previous PR.
Which issue(s) this PR fixes:
Fixes #109295
Special notes for your reviewer:
Did full test using the real e2e_node binary and the test machinery like this:
make test-e2e-node FOCUS='Node Performance Testing \[Serial\] \[Slow\] Run node performance testing with pre-defined workloads TensorFlow workload' SKIP="QQQQQ"
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: