Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: enable etcd's learner mode when joining etcd members #113318

Merged
merged 3 commits into from Dec 17, 2022
Merged

kubeadm: enable etcd's learner mode when joining etcd members #113318

merged 3 commits into from Dec 17, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Oct 25, 2022 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref kubernetes/kubeadm#1793

Special notes for your reviewer:

similar implementation: https://github.com/siderolabs/talos/blob/fc48849d00c185442fb37c72e2c20462cc573a69/internal/app/machined/pkg/system/services/etcd.go#L589-L631

Does this PR introduce a user-facing change?

kubeadm: add the experimental (alpha) feature gate EtcdLearnerMode that allows etcd members to be joined as learner and only then promoted as voting members

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

To be edited after KEP is merged.

- [KEP]: https://github.com/kubernetes/enhancements/issues/3614

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2022
@pacoxu pacoxu marked this pull request as draft October 25, 2022 07:11
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2022
@neolit123
Copy link
Member

i will find time to update the kep this week

@pacoxu pacoxu force-pushed the learner-mode branch 2 times, most recently from d438c47 to 2a6fa9f Compare October 25, 2022 10:53
@pacoxu pacoxu marked this pull request as ready for review October 25, 2022 10:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2022
@pacoxu pacoxu marked this pull request as draft October 25, 2022 14:39
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2022
@pacoxu pacoxu marked this pull request as ready for review October 25, 2022 14:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2022
@k8s-ci-robot k8s-ci-robot requested review from johnbelamaric and a team October 25, 2022 14:51
@chendave
Copy link
Member

/lgtm
/hold
leave @neolit123 for a final check

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 16, 2022
@pacoxu
add etcd as learner mode and promote when fg EtcdLearnerMode is enabled
b3deecf 
- use etcd backoff to wait; still has many warning messages
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2022
@pacoxu pacoxu force-pushed the learner-mode branch 2 times, most recently from ef316ba to f0c43f3 Compare December 17, 2022 03:05
SataQiu
SataQiu reviewed Dec 17, 2022
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over all LGTM, thanks

cmd/kubeadm/app/util/etcd/etcd.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/etcd/etcd.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/etcd/etcd.go Outdated Show resolved Hide resolved
SataQiu
SataQiu approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 386de886ffdf6879764e1db112442c1e0d4c199c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented Dec 17, 2022

/test pull-kubernetes-unit

@pacoxu
Copy link
Member Author

pacoxu commented Dec 17, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit fdafd50 into kubernetes:master Dec 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 17, 2022
@pacoxu pacoxu mentioned this pull request Jan 10, 2023
Open
@sbueringer sbueringer mentioned this pull request Jan 12, 2023
Closed
@tobiasgiese tobiasgiese mentioned this pull request Jan 12, 2023
Merged
@pacoxu pacoxu mentioned this pull request Jan 31, 2023
Open
8 tasks
@zmedico zmedico mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@chendave chendave chendave left review comments

@SataQiu SataQiu SataQiu approved these changes

Assignees

@chendave chendave

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacoxu @neolit123 @chendave @k8s-ci-robot @SataQiu @liggitt