Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger unmarshaljson #113338

Merged
merged 1 commit into from Oct 26, 2022
Merged

Swagger unmarshaljson #113338

merged 1 commit into from Oct 26, 2022

Conversation

apelisse
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use Swagger#UnmarhsalJson rather than json.Unmarshal to deserialize OpenAPI spec since there is a 2x overhead with json.Unmarshal now that we're using the experimental json deserializer.

Which issue(s) this PR fixes:

Follow up from #112988

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2022
@apelisse
Copy link
Member Author

cc @alexzielenski @liggitt

@apelisse
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 25, 2022
@apelisse
Use Swagger#UnmarshalJSON rather than json.Unmarshal
5be7430 
Since we're now using the experimental json code to deserialize
spec.Swagger, we should rather use UnmarshalJSON since this has a much
lower CPU overhead.
@apelisse
Copy link
Member Author

Remaining usages of json.Marshal are in tests, and mostly irrelevant.

@alexzielenski
Copy link
Contributor

/lgtm
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2022
@liggitt
Copy link
Member

liggitt commented Oct 25, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022
@apelisse
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d77d28b into kubernetes:master Oct 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@alexzielenski alexzielenski

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@apelisse @alexzielenski @liggitt @k8s-ci-robot