Simplify go.mod #113424
Merged
Simplify go.mod #113424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
liggitt
commented
Oct 28, 2022
liggitt
force-pushed
the
simplify-go.mod
branch
from
36f0e77
to
30701b9
Compare
dims
reviewed
Oct 28, 2022
|
I like it! good direction @liggitt. thanks! |
k8s-ci-robot
added
the
needs-rebase
liggitt
force-pushed
the
simplify-go.mod
branch
from
30701b9
to
1cb0a1c
Compare
k8s-ci-robot
removed
the
needs-rebase
|
rebased, fixed lint error with unused method it looks like check-dependency-stats has the same issue with the expanded graph, will dig into that |
liggitt
force-pushed
the
simplify-go.mod
branch
from
1cb0a1c
to
93f9ced
Compare
liggitt
force-pushed
the
simplify-go.mod
branch
from
93f9ced
to
6076987
Compare
k8s-ci-robot
added
area/cloudprovider
sig/cloud-provider
|
depstat fix in kubernetes-sigs/depstat#65 |
This was originally added in the early days of go.mod in order to ensure that the root k8s.io/kubernetes go.mod file reflected all the versions of dependencies we were using, and to ensure that go commands didn't spuriously increment these versions. With module pruning in go1.17+ and go defaulting to mod=readonly mode in go1.16+, this is no longer necessary.
liggitt
force-pushed
the
simplify-go.mod
branch
from
6076987
to
f488c67
Compare
|
/retest |
|
/test check-dependency-stats |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/approve Thanks @liggitt |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Stops adding explicit
replacedirectives for all dependencies. This was needed in the early days of go.mod to ensure we had a consistent root view of the required dependency versions and to keep spurious changes from happening to go.mod, but both of those issues have been resolved since go1.17.A nice side effect is that dependency updates should no longer require several pin/update-vendor/lint cycles.
This also fixes up the unwanted-dependencies scanner to work with the expanded
go mod graphoutput that results from dropping the forced pins to specific versions.Requires depstat fix in kubernetes-sigs/depstat#65 before CI will pass on this PR
/cc @dims
/area code-organization