Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #112693: Fixed (CVE-2022-27664) Bump golang.org/x/net to #113425

Merged
merged 1 commit into from Nov 16, 2022
Merged

Automated cherry pick of #112693: Fixed (CVE-2022-27664) Bump golang.org/x/net to #113425

merged 1 commit into from Nov 16, 2022

Conversation

aimuz
Copy link
Contributor

@aimuz aimuz commented Oct 28, 2022

Cherry pick of #112693 on release-1.25.

#112693: Fixed (CVE-2022-27664) Bump golang.org/x/net to

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Oct 28, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @aimuz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl labels Oct 28, 2022
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 28, 2022
@k8s-ci-robot k8s-ci-robot requested a review from a team October 28, 2022 07:38
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 28, 2022
@pacoxu
Copy link
Member

pacoxu commented Oct 28, 2022

/lgtm
/assign @liggitt

@aimuz
Copy link
Contributor Author

aimuz commented Oct 31, 2022

@xmudrii Okay, I'll cherry-pick the past

@aimuz
Copy link
Contributor Author

aimuz commented Oct 31, 2022

@xmudrii #113459

@liggitt
Copy link
Member

liggitt commented Oct 31, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@RainbowMango
Copy link
Member

/cc kubernetes/release-managers
For dealing with the do-not-merge/cherry-pick-not-approved label.

@RainbowMango
Copy link
Member

/cc @kubernetes/release-managers

@cpanato
Copy link
Member

cpanato commented Nov 1, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 1, 2022
@aimuz aimuz mentioned this pull request Nov 1, 2022
Merged
@RainbowMango
Copy link
Member

Hi @cpanato Could you please help to approve this? The PR is blocked by the do-not-merge/cherry-pick-not-approved label.
Also ping other release managers. @kubernetes/release-managers .

@xmudrii
Copy link
Member

xmudrii commented Nov 9, 2022

@RainbowMango We are past cherry-pick deadline for the November patch releases. We'll resume merging cherry-picks starting next week.

@RainbowMango
Copy link
Member

Do you mean this will not be included in the coming v1.25.4?

@xmudrii
Copy link
Member

xmudrii commented Nov 9, 2022

@RainbowMango That's right -- it'll not be included in the upcoming 1.25.4 patch release.

@RainbowMango
Copy link
Member

What a pity! But thanks for the notice.

@enj enj added this to Needs Triage in SIG Auth Old Nov 14, 2022
@liggitt
Copy link
Member

liggitt commented Nov 15, 2022

cc @kubernetes/release-managers this is ready for 1.25

we're still working on prereqs for getting the fix merged to earlier branches, but it is worthwhile to get it into 1.25 at least

xmudrii
xmudrii approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

SIG Auth Old automation moved this from Needs Triage to In Progress Nov 15, 2022
@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aimuz
Copy link
Contributor Author

aimuz commented Nov 16, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit c8d0fbe into kubernetes:release-1.25 Nov 16, 2022
SIG Node PR Triage automation moved this from Triage to Done Nov 16, 2022
SIG Auth Old automation moved this from In Progress to Closed / Done Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@liggitt liggitt

@pacoxu pacoxu

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Done
[sig-architecture] Dependency management
Status: Done
SIG Auth Old
Closed / Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aimuz @k8s-ci-robot @pacoxu @xmudrii @liggitt @RainbowMango @cpanato