Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grpc probe log #113582

Merged
merged 1 commit into from Nov 8, 2022
Merged

Fix grpc probe log #113582

merged 1 commit into from Nov 8, 2022

Conversation

wzshiming
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/113580/pull-kubernetes-node-e2e-containerd/1588098680102064128/artifacts/tmp-node-e2e-738c1ab5-ubuntu-gke-2204-1-24-v20221101/kubelet.log

I1103 09:34:38.463593    2134 prober.go:175] "GRPC-Probe" host=0xc000f477d8 service=0xc00044ed30 port=2333 timeout="5s"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 3, 2022
@wzshiming
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 3, 2022
@wzshiming
Copy link
Member Author

/cc @yuzhiquan @bowei @PxyUp @SergeyKanzhelev

@k8s-ci-robot
Copy link
Contributor

@wzshiming: GitHub didn't allow me to request PR reviews from the following users: PxyUp.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yuzhiquan @bowei @PxyUp @SergeyKanzhelev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022
@bobbypage
Copy link
Member

bobbypage commented Nov 7, 2022 •
edited

Fix makes sense, lgtm, thanks!

@yuzhiquan
Copy link
Member

/lgtm

@wzshiming wzshiming added this to Triage in SIG Node Bugs Nov 7, 2022
@wzshiming
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2022
@wzshiming wzshiming moved this from Triage to Triaged in SIG Node Bugs Nov 7, 2022
@dims
Copy link
Member

dims commented Nov 8, 2022

fixes log when GRPCContainerProbe is switched on. I am comfortable getting this in. has 2 lgtms

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit b3082c5 into kubernetes:master Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 8, 2022
@wzshiming wzshiming deleted the fix/grpc-probe-log branch November 9, 2022 02:16
@SergeyKanzhelev SergeyKanzhelev moved this from Triaged to High Priority in SIG Node Bugs Dec 9, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from High Priority to Done in SIG Node Bugs Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzhiquan yuzhiquan Awaiting requested review from yuzhiquan

@bowei bowei Awaiting requested review from bowei

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@bobbypage bobbypage

@yuzhiquan yuzhiquan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node Bugs
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wzshiming @k8s-ci-robot @bobbypage @yuzhiquan @dims