Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix etcd path construction #113696

Merged
merged 1 commit into from Nov 8, 2022
Merged

Fix etcd path construction #113696

merged 1 commit into from Nov 8, 2022

Conversation

tallclair
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes etcd path construction to handle invalid input.

Does this PR introduce a user-facing change?

NONE

/sig api-machinery
/milestone v1.26

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 7, 2022
@tallclair
Copy link
Member Author

/assign @lavalamp @deads2k @liggitt @wojtek-t

@tallclair
Copy link
Member Author

Note: the unit tests in this patch differ significantly from the v1.25 and older versions (#113684) due to a number of test refactors on the master branch, such as e49c225 and 75a1ef8

@tallclair
Copy link
Member Author

/retest

@deads2k
Copy link
Contributor

deads2k commented Nov 7, 2022

/lgtm
/hold for other reviewers

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 7, 2022
@liggitt
Copy link
Member

liggitt commented Nov 7, 2022

/lgtm
/approve

@liggitt
Copy link
Member

liggitt commented Nov 7, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit aa66cec into kubernetes:master Nov 8, 2022
@wojtek-t
Copy link
Member

wojtek-t commented Nov 8, 2022

Thanks for fixing this Tim!

@stevekuznetsov - FYI

@wojtek-t
Copy link
Member

wojtek-t commented Nov 8, 2022

[For posterity - this LGTM too]

@wojtek-t wojtek-t mentioned this pull request Nov 8, 2022
Merged
This was referenced Nov 8, 2022
Closed
Closed
@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@lavalamp lavalamp

@liggitt liggitt

@deads2k deads2k

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tallclair @deads2k @liggitt @k8s-ci-robot @wojtek-t @alexzielenski @lavalamp