apiserver: use the correct error when logging errors updating managedFields #113711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
andrewsykim
commented
Nov 8, 2022
| @@ -202,8 +202,8 @@ func (f *FieldManager) UpdateNoErrors(liveObj, newObj runtime.Object, manager st | |||
| if err != nil { | |||
| atMostEverySecond.Do(func() { | |||
| ns, name := "unknown", "unknown" | |||
| accessor, err := meta.Accessor(newObj) | |||
| if err == nil { | |||
| accessor, accessorErr := meta.Accessor(newObj) | |||
There was a problem hiding this comment.
Otherwise error log on line 211 uses a nil err
k8s-ci-robot
added
area/apiserver
sig/api-machinery
|
/assign @apelisse |
|
/lgtm
/retest |
k8s-ci-robot
added
the
lgtm
andrewsykim
commented
Nov 8, 2022
There was a problem hiding this comment.
/assign @lavalamp
Also generally curious if we should be concerned that this is logging
apelisse
reviewed
Nov 8, 2022
Comment on lines
205
to
208
| accessor, accessorErr := meta.Accessor(newObj) | ||
| if accessorErr == nil { | ||
| ns = accessor.GetNamespace() | ||
| name = accessor.GetName() | ||
| } |
There was a problem hiding this comment.
Wouldn't it be cuter to do:
Suggested change
| accessor, accessorErr := meta.Accessor(newObj) | |
| if accessorErr == nil { | |
| ns = accessor.GetNamespace() | |
| name = accessor.GetName() | |
| } | |
| if accessor, err := meta.Accessor(newObj); err == nil { | |
| ns = accessor.GetNamespace() | |
| name = accessor.GetName() | |
| } |
I guess we'll only be able to tell once we see the error :-) |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
…Fields Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
andrewsykim
force-pushed
the
fieldmanager-logging
branch
from
fb0e4ce
to
efdd067
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
1 similar comment
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, apelisse, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Sy Kim andrewsy@google.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
I noticed that
[SHOULD NOT HAPPEN] failed to update managedFieldswas being logged but there was no error logged with it. After looking at the code, it's because the err passed intoklog.ErrorSis the nil error frommeta.Accessor(newObj)when it should be the err from trying to updatemanagedFieldsWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: