Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade runc to v1.1.4 #113719

Merged
merged 1 commit into from Nov 8, 2022
Merged

upgrade runc to v1.1.4 #113719

merged 1 commit into from Nov 8, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Nov 8, 2022

What type of PR is this?

/kind bug
/priority important-soon
/sig node
/cc @dims @bobbypage @liggitt @kolyshkin

What this PR does / why we need it:

https://github.com/opencontainers/runc/releases/tag/v1.1.4

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

bump runc to v1.1.4

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Nov 8, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Nov 8, 2022

/test check-dependency-stats

1 similar comment
@liggitt
Copy link
Member

liggitt commented Nov 8, 2022

/test check-dependency-stats

@liggitt
Copy link
Member

liggitt commented Nov 8, 2022 •
edited

looks like the CI failure is a known issue, being discussed in https://kubernetes.slack.com/archives/C7J9RP96G/p1667877096344719 - kubernetes/test-infra#27919

@liggitt
Copy link
Member

liggitt commented Nov 8, 2022

dependency update lgtm, will defer to node reviewer for lgtm of the specific runc change

@dims
Copy link
Member

dims commented Nov 8, 2022

this is legit!

/approve
/lgtm
/hold for additional sig-node eyes

/assign @klueska @mrunalp

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2022
@klueska
Copy link
Contributor

klueska commented Nov 8, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, klueska, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented Nov 8, 2022

/unhold
Thanks for your review.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit e21438f into kubernetes:master Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage Awaiting requested review from bobbypage

@dims dims Awaiting requested review from dims

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@mrunalp mrunalp

@klueska klueska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacoxu @k8s-ci-robot @liggitt @dims @klueska @mrunalp