Standardize naming in generic storage watcher tests #113721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
priority/important-longterm
wojtek-t
commented
Nov 8, 2022
| @@ -44,65 +44,76 @@ func RunTestWatch(ctx context.Context, t *testing.T, store storage.Interface) { | |||
| // - update should trigger Modified event | |||
| // - update that gets filtered should trigger Deleted event | |||
| func testWatch(ctx context.Context, t *testing.T, store storage.Interface, recursive bool) { | |||
| podFoo := &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}} | |||
| podBar := &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "bar"}} | |||
| basePod := &example.Pod{ | |||
wojtek-t
force-pushed
the
storage_standard_test_naming_2
branch
from
e903edc
to
7510d5c
Compare
wojtek-t
force-pushed
the
storage_standard_test_naming_2
branch
from
7510d5c
to
593742f
Compare
|
/retest |
stevekuznetsov
approved these changes
Nov 8, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
logicalhan
reviewed
Nov 8, 2022
Comment on lines
+99
to
+105
| watchKey := fmt.Sprintf("pods/%s", tt.namespace) | ||
| key := watchKey + "/foo" | ||
| if !recursive { | ||
| watchKey = key | ||
| } | ||
|
|
||
| w, err := store.Watch(ctx, watchKey, storage.ListOptions{ResourceVersion: "0", Predicate: tt.pred, Recursive: recursive}) |
There was a problem hiding this comment.
nice this is way more readable
Comment on lines
-99
to
-102
| key := tt.key | ||
| if recursive { | ||
| key = key + "/item" | ||
| } |
k8s-ci-robot
added
the
lgtm
|
/milestone v1.26 [This was tagged before code-freeze, and in addition this is test-only change.] |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #109831
/kind cleanup
/priority important-longterm
/sig api-machinery
/assign @stevekuznetsov
/cc @tallclair