fix possible race of listwatch in admission test #113760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
alexzielenski
force-pushed
the
admission-listwatch-flake
branch
from
65ce5df
to
f383dfc
Compare
logicalhan
reviewed
Nov 8, 2022
staging/src/k8s.io/apiserver/pkg/admission/plugin/cel/admission_test.go
Outdated
Show resolved
Hide resolved
alexzielenski
force-pushed
the
admission-listwatch-flake
branch
from
f383dfc
to
4e21715
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
test-only change to deflake a test, so adding to milestone ahead of 1.26 test freeze |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a race in test code caused by the fact that the fake object tracker does not respect the lastSyncedResource version option when a watch Is started, so any objects added by a test between the list and watch of the informers might be dropped.
This change creates a noop policy bindings and policy definitions and keeps updating them until the update is noticed by the controller, to show that watch is established. Then the test is allowed to continue.
This bug was reproduced using the
stresstool with-race. It occurred on my machine about 0.05% of the time. After this change there are failures 0% of the time measured usingstress.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @jpbetz @logicalhan