New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick of #112074: e2e: use custom timeouts in GetSnapshotContentFromSnapshot() #113817
Conversation
@AnishShah: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @AnishShah. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
In the title, can you reference the PR that you are cherry picking? For future reference, this script makes the cherry picking process easier: https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh |
/lgtm |
/cc kubernetes/release-managers |
Any reason to not backport this to 1.23/24? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AnishShah, msau42, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
This patch replaces a hardcoded timeout for volume deletion and use the custom timeout instead. This was fixed in 1.26 but I'm backporting it to 1.25.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: