Removed factory from apply command flag struct

[lauchokyip]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

kubectl FlagStruct should not consist of the Factory based of #112714 (comment)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Nov 20 15:27:35 UTC 2022.

[k8s-ci-robot]

@lauchokyip: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[PuneetPunamiya]

Would it be better to use resource.NewBuilder function instead this

[lauchokyip]

factory.NewBuilder() is an interface whereas resource.NewBuilder is a concrete function, which mean if you initialize the factory as a TestFactory instead of a normal Factory, then f.Builder() can be implemented and behave differently.

That's why I think factory.NewBuidler() is better

[dims]

If you still need this PR then please rebase, if not, please close the PR

[brianpursley]

Can factory be removed altogether from the apply package?

See the wait command as an example:
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go#L118

[lauchokyip]

Can factory be removed altogether from the apply package?

See the wait command as an example: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go#L118

It can't be easily get rid of yet, see this comment
https://github.com/kubernetes/kubernetes/pull/112951/files#r1008841803

[brianpursley]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2e5c5ee841fe6872de99516118cf9ce103eb7bfb

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, lauchokyip

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [brianpursley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment