Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #114122: Fix endpoint reconciler failing to delete masterlease #114138

Merged
merged 1 commit into from Nov 26, 2022
Merged

Automated cherry pick of #114122: Fix endpoint reconciler failing to delete masterlease #114138

merged 1 commit into from Nov 26, 2022

Conversation

aojea
Copy link
Member

@aojea aojea commented Nov 25, 2022 •
edited by liggitt

Cherry pick of #114122 on release-1.24.

#114122: Fix endpoint reconciler failing to delete masterlease

For details on the cherry pick process, see the cherry pick requests page.

Fix a 1.24.8 regression with endpoint reconciler not being able to delete the apiserver lease on shutdown

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 25, 2022
@aojea
Copy link
Member Author

aojea commented Nov 25, 2022

/kind bug
/kind regression

I have to carry on with all the refactor commits but are mostly test changes and some cleanup
/assign @liggitt @xmudrii

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 25, 2022
@aojea aojea mentioned this pull request Nov 25, 2022
Closed
@wojtek-t @aojea
Fix endpoint reconciler failing to delete masterlease
b970b6b 
add regression test as a different file for endpoint reconciler leases,
since the original test can not be backported cleanly.
@aojea aojea force-pushed the automated-cherry-pick-of-#107878-#114122-upstream-release-1.24 branch from b0f5144 to b970b6b Compare November 26, 2022 10:48
@aojea aojea changed the title Automated cherry pick of #107878: Use t.Run() consistently in reconciler unit tests #114122: Fix endpoint reconciler failing to delete masterlease Automated cherry pick of #114122: Fix endpoint reconciler failing to delete masterlease Nov 26, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 26, 2022
@liggitt
Copy link
Member

liggitt commented Nov 26, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2022
@liggitt
Copy link
Member

liggitt commented Nov 26, 2022

/priority critical-urgent
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 26, 2022
@liggitt
Copy link
Member

liggitt commented Nov 26, 2022

cc @kubernetes/release-managers

This was referenced Nov 26, 2022
Closed
Merged
Merged
xmudrii
xmudrii approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 26, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e72eea9 into kubernetes:release-1.24 Nov 26, 2022
k8s-ci-robot added a commit that referenced this pull request Nov 26, 2022
@k8s-ci-robot
Merge pull request #114153 from aojea/automated-cherry-pick-of-#11413…
7f08c5c 
…8-upstream-release-1.23

Automated cherry pick of #114138: Fix endpoint reconciler failing to delete masterlease
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2022
@k8s-ci-robot
Merge pull request #114154 from aojea/automated-cherry-pick-of-#11413…
7039932 
…8-upstream-release-1.22

Automated cherry pick of #114138: Fix endpoint reconciler failing to delete masterlease
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@xmudrii xmudrii xmudrii approved these changes

@thockin thockin Awaiting requested review from thockin

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@liggitt liggitt

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aojea @liggitt @k8s-ci-robot @xmudrii @wojtek-t