Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip resize if fs is readonly #114325

Merged
merged 3 commits into from Dec 16, 2022
Merged

Skip resize if fs is readonly #114325

merged 3 commits into from Dec 16, 2022

Conversation

judemars
Copy link
Contributor

@judemars judemars commented Dec 7, 2022 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

See kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1088. Right now we attempt a filesystem resize without checking whether it's readonly. This change checks the readonly bit of the filesystem, and skips resizing if it is set to "1".

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Dec 6 21:54:24 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

@judemars: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @judemars. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 7, 2022
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 7, 2022
@judemars
Copy link
Contributor Author

judemars commented Dec 7, 2022

/assign saikat-royc
/assign leiyiz

@leiyiz
Copy link
Contributor

leiyiz commented Dec 8, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2022
@leiyiz
Copy link
Contributor

leiyiz commented Dec 8, 2022

/retest

@judemars
Copy link
Contributor Author

/assign @xing-yang

@gnufied
Copy link
Member

gnufied commented Dec 12, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@judemars
Copy link
Contributor Author

/retest

leiyiz
leiyiz reviewed Dec 12, 2022
View reviewed changes
staging/src/k8s.io/mount-utils/resizefs_linux.go Outdated
output, err := resizefs.exec.Command(blockDev, "--getro", devicePath).CombinedOutput()
outStr := strings.TrimSpace(string(output))
if err != nil {
return false, fmt.Errorf("failed to read size of device %s: %s: %s", devicePath, err, outStr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should the log here be failed to get read-only .... or something similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, fixed. Thank you!

@leiyiz
Copy link
Contributor

leiyiz commented Dec 12, 2022

/approve
please squash and will lgtm

@leiyiz
Copy link
Contributor

leiyiz commented Dec 12, 2022

ahh looks like I don't have approval power

@gnufied
Copy link
Member

gnufied commented Dec 12, 2022

I will approve but although a nit, it would be good to have log message fixed.

@judemars
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 13, 2022
@judemars
Copy link
Contributor Author

@leiyiz I set the merge method to squash, I think it's easier that way in case of last minute changes

@judemars
Copy link
Contributor Author

/retest

@gnufied
Copy link
Member

gnufied commented Dec 13, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@judemars
Copy link
Contributor Author

/assign @jsafrane

@jsafrane
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane, judemars, leiyiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 94fd5bd into kubernetes:master Dec 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 16, 2022
@judemars judemars mentioned this pull request Dec 21, 2022
Closed
jaehnri pushed a commit to jaehnri/kubernetes that referenced this pull request Jan 3, 2023
@judemars @jaehnri
Skip resize if fs is readonly (kubernetes#114325)
bd87d72 
* skip resize if fs is readonly

* run formatter + add log line for early return case

* fix error
@judemars judemars mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz leiyiz left review comments

@gnufied gnufied Awaiting requested review from gnufied

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@gnufied gnufied

@xing-yang xing-yang

@jsafrane jsafrane

@leiyiz leiyiz

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@judemars @k8s-ci-robot @leiyiz @gnufied @jsafrane @xing-yang @saikat-royc