Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for initial kubelet certificates more frequently #114367

Merged
merged 1 commit into from Jan 30, 2023
Merged

Check for initial kubelet certificates more frequently #114367

merged 1 commit into from Jan 30, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 8, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Improves response time of kubelet to initial client certificate issuance

Which issue(s) this PR fixes:

Related to #112170

Special notes for your reviewer:

Alternative to #112240

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Dec 8 11:56:23 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 8, 2022
@liggitt liggitt mentioned this pull request Dec 8, 2022
Closed
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2022
@dims
Copy link
Member

dims commented Dec 12, 2022

This PR has the label work-in-progress, please revisit to see if you still need this, please close if not

@bart0sh bart0sh moved this from Triage to Waiting on Author in SIG Node PR Triage Jan 2, 2023
@chenk008
Copy link
Contributor

It looks good to me. @liggitt Is there anything else that I can do to help expedite the PR process?

@liggitt liggitt changed the title WIP - Check for initial kubelet certificates more frequently Check for initial kubelet certificates more frequently Jan 13, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2023
@liggitt liggitt requested review from deads2k and removed request for thockin January 13, 2023 16:33
@liggitt
Copy link
Member Author

liggitt commented Jan 13, 2023

I'm pretty happy with the shape of this.

/hold for review
cc @mikedanese @deads2k to take a look

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2023
@bart0sh bart0sh moved this from Waiting on Author to Needs Reviewer in SIG Node PR Triage Jan 27, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jan 27, 2023

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 27, 2023
@liggitt
Copy link
Member Author

liggitt commented Jan 30, 2023

cc @enj for review

@enj
Copy link
Member

enj commented Jan 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: edb7be5d4a88e27204b0db4fe4d74af8a66d87bd

@enj enj mentioned this pull request Jan 30, 2023
Open
@liggitt
Copy link
Member Author

liggitt commented Jan 30, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit d058417 into kubernetes:master Jan 30, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 30, 2023
@liggitt liggitt deleted the kubelet-csr-init branch May 9, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @k8s-ci-robot @dims @chenk008 @bart0sh @enj