@daman1807: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Welcome @daman1807!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@daman1807: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Hi @daman1807. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

/retest

Hey @daman1807 Thanks for taking a look at this, It looks like you added a test to the legacy network policy suite, that's good but I think what's more important is adding it to newer truthtable tests found here -> https://github.com/kubernetes/kubernetes/blob/master/test/e2e/network/netpol/network_policy.go

@astoycos I looked into network_policy.go and found only intra-pod connectivity(E/W) tests by asserting on truth tables. In this case, we need to test N/S ingress traffic and I don't think it will be possible to do it with current truth table structures. In network_legacy.go I found similar tests which validated connectivity on services rather than pods and also a pod and service are initialized in Ginko context before each test in network_policy.go so I decided to put the test there.

Should I just move the test to network_policy.go and validate without using truth tables?

Hrm I think we should still be using the truth tables/ new style tests and no adding a test which doesn't use the new tables to the new code probably isn't the right route either....we may just need to add the required functionality to the truth table functions. I'll have to take a fresh look to see how difficult it'll be but ultimately that seems like the right way forward.

@astoycos Can I create a similar matrix and reachability tests for N/S traffic?
The original will work for E/W traffic

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daman1807

The full list of commands accepted by this bot can be found here.