Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We forgot to remove the old netpol tests that are covered by new matrix based tests #114389

Closed
jayunit100 opened this issue Dec 9, 2022 · 5 comments · Fixed by #118915
Closed

We forgot to remove the old netpol tests that are covered by new matrix based tests #114389

jayunit100 opened this issue Dec 9, 2022 · 5 comments · Fixed by #118915
Assignees
@jayunit100 @astoycos
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jayunit100
Copy link
Member

What happened?

we can follow up on #102933 now, by finishing removing all but the SCTP tests in the old legacy filters.

What did you expect to happen?

we would have removed the old tests by now :) but we didnt wanna break OVN . I think OVN CI is passing now w/ the new tests though so we're good !

How can we reproduce it (as minimally and precisely as possible)?

NA

Anything else we need to know?

No response

Kubernetes version

main

Cloud provider

all

OS version

all

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)
@jayunit100 jayunit100 added the kind/bug Categorizes issue or PR as related to a bug. label Dec 9, 2022
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

@jayunit100: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jayunit100
Copy link
Member Author

/sig network
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 9, 2022
@astoycos
Copy link
Contributor

astoycos commented Dec 9, 2022

/cc

@jayunit100
Copy link
Member Author

/assign

@astoycos astoycos mentioned this issue Dec 12, 2022
Merged
@thockin thockin added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 21, 2022
@astoycos
Copy link
Contributor

/assign

I can take care of this one.

@astoycos astoycos mentioned this issue Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayunit100 jayunit100

@astoycos astoycos

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove legacy NetworkPolicy tests astoycos/kubernetes
4 participants
@jayunit100 @thockin @k8s-ci-robot @astoycos