Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the reverted changes from Changelogv1.26.md #114602

Merged
merged 1 commit into from Dec 21, 2022
Merged

Removed the reverted changes from Changelogv1.26.md #114602

merged 1 commit into from Dec 21, 2022

Conversation

Shubham82
Copy link
Contributor

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

This PR removed the below context from the Changelog.md v1.26, as this PR #112127 has been reverted by PR #113733 in v1.26 and it was missed out to remove that point.

Fixed DaemonSet to update the status even if it fails to create a pod. (#112127, @gjkim42)

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 20, 2022
@k8s-ci-robot
Copy link
Contributor

@Shubham82: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 20, 2022
@Shubham82
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 20, 2022
@Shubham82
Copy link
Contributor Author

Hi @laxmikantbpandhare, @ramrodo
PTAL!

@Shubham82
Copy link
Contributor Author

Once it will merge, then will cherry-pick the fix to the release-1.26 branch.

@Shubham82 Shubham82 mentioned this pull request Dec 20, 2022
Closed
@alculquicondor
Copy link
Member

/release-note-none
/lgtm

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 20, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 85f5bff1e909246f8c6aed4d080aba81ecf19f32

@ramrodo
Copy link
Member

ramrodo commented Dec 20, 2022

Thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramrodo, Shubham82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit e218e0e into kubernetes:master Dec 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 21, 2022
Shubham82 added a commit to Shubham82/kubernetes that referenced this pull request Jan 5, 2023
@Shubham82
Automated cherry pick of kubernetes#114602: Removed the reverted chan…
c25004b 
…ges from Changelogv1.26.md
@Shubham82 Shubham82 mentioned this pull request Jan 5, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 16, 2023
@k8s-ci-robot
Merge pull request #114838 from Shubham82/cherry-pick-of-#114602-upst…
1c5bdd5 
…ream-release-1.26

Automated cherry pick of #114602: Removed the reverted changes from Changelogv1.26.md
nyodas pushed a commit to DataDog/kubernetes that referenced this pull request Jan 26, 2023
@Shubham82 @nyodas
Automated cherry pick of kubernetes#114602: Removed the reverted chan…
5a87b83 
…ges from Changelogv1.26.md
@sanchezl sanchezl mentioned this pull request Feb 16, 2023
Merged
nerzhul pushed a commit to nerzhul/kubernetes that referenced this pull request Feb 18, 2023
@Shubham82 @nerzhul
Automated cherry pick of kubernetes#114602: Removed the reverted chan…
5fa67ff 
…ges from Changelogv1.26.md
@sanchezl sanchezl mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laxmikantbpandhare laxmikantbpandhare Awaiting requested review from laxmikantbpandhare

@ramrodo ramrodo Awaiting requested review from ramrodo

Assignees

@alculquicondor alculquicondor

@ramrodo ramrodo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shubham82 @k8s-ci-robot @alculquicondor @ramrodo