Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ROX storage tests #114628

Merged
merged 9 commits into from Apr 26, 2023
Merged

Add ROX storage tests #114628

merged 9 commits into from Apr 26, 2023

Conversation

judemars
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Adds ROX k8s CSI integration tests.

Adds tests for restoring from snapshot and clone in ReadOnlyMany mode. It tests that the new pvcs contain the source data, as well as that the new volumes are not resized (since the fs is readonly).

Some of the resize testing code is based from https://github.com/kubernetes/kubernetes/pull/110304/files (adding test for fs resize) which isn't merged yet at the time of this writing.

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1088

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @judemars. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Dec 21, 2022
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 21, 2022
@judemars
Copy link
Contributor Author

/assign @RomanBednar
/assign @saikat-royc
/assign @leiyiz

@judemars judemars closed this Dec 21, 2022
@judemars judemars reopened this Dec 21, 2022
@mattcary
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2022
@leiyiz
Copy link
Contributor

leiyiz commented Dec 29, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2022
@k8s-ci-robot k8s-ci-robot removed sig/release Categorizes an issue or PR as relevant to SIG Release. sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Apr 26, 2023
@mengjiao-liu
Copy link
Member

/remove-area apiserver
/remove-area cloudprovider
/remove-area kubeadm
/remove-area kubectl
/remove-area kubelet
/remove-area code-generation
/remove-area dependency
/remove-area ipvs
/remove-area provider-gcp
/remove-area release-eng

@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: Those labels are not set on the issue: area/provider-gcp

In response to this:

/remove-area apiserver
/remove-area cloudprovider
/remove-area kubeadm
/remove-area kubectl
/remove-area kubelet
/remove-area code-generation
/remove-area dependency
/remove-area ipvs
/remove-area provider-gcp
/remove-area release-eng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mengjiao-liu
Copy link
Member

/remove-kind api-change
/remove-area provider/gcp

@k8s-ci-robot k8s-ci-robot removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/provider/gcp Issues or PRs related to gcp provider labels Apr 26, 2023
@msau42
Copy link
Member

msau42 commented Apr 26, 2023

/lgtm
/approve
/skip

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: afcec31e41a5845f24330de54d638d84aa636ee1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: judemars, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 217196c into kubernetes:master Apr 26, 2023
16 checks passed
SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Apr 26, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Apr 26, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 26, 2023
@bertinatto bertinatto mentioned this pull request Jun 20, 2023
Closed
rayowang pushed a commit to rayowang/kubernetes that referenced this pull request Feb 9, 2024
@judemars
Add ROX storage tests (kubernetes#114628)
acc579f 
* Add ROX tests

* Add capability and switch to secpod

* addmissing file

* remove extra param

* run-formatter

* add anticapability for resize w/ Restore + ROX

* remove size checking in ROX tests

* fix spacing

* fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@msau42 msau42 msau42 left review comments

@mattcary mattcary mattcary left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@johnSchnake johnSchnake Awaiting requested review from johnSchnake

@leiyiz leiyiz Awaiting requested review from leiyiz

@RomanBednar RomanBednar Awaiting requested review from RomanBednar

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@RomanBednar RomanBednar

@msau42 msau42

@leiyiz leiyiz

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
[sig-windows] PR tracking
Status: Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

read only volumes should not be expanded and we need OSS ROX testing