Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add k8s node-role.kubernetes.io/control-plane taint #114759

Merged
merged 1 commit into from Feb 1, 2023
Merged

chore: add k8s node-role.kubernetes.io/control-plane taint #114759

merged 1 commit into from Feb 1, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jan 2, 2023

node-role.kubernetes.io/master has been deprecated from 1.20, and replaced by node-role.kubernetes.io/control-plane.

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.20.md
image

/kind cleanup

@my-git9
chroe: add k8s node-role.kubernetes.io/control-plane taint
10ca605 
Signed-off-by: xin.li <xin.li@daocloud.io>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 2, 2023
@my-git9 my-git9 changed the title chroe: add k8s node-role.kubernetes.io/control-plane taint chore: add k8s node-role.kubernetes.io/control-plane taint Jan 2, 2023
@my-git9
Copy link
Member Author

my-git9 commented Jan 2, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 2, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 2, 2023
@matthyx
Copy link
Contributor

matthyx commented Jan 2, 2023

/triage accepted
/priority important-longterm
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 2, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e3620e6a1e33eb7ceedc25bb0d414bcc5f6e412a

@pacoxu
Copy link
Member

pacoxu commented Jan 3, 2023

/assign @endocrimes @KnVerey

@KnVerey
Copy link
Contributor

KnVerey commented Jan 3, 2023

/approve for SIG CLI

@endocrimes
Copy link
Member

/hold
/approve

we don't run these tests in kubernetes CI, so cc @fromanirh and @swatisehgal (as it does run in RH CI) for a final confirmation. Otherwise this lgtm.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: endocrimes, KnVerey, my-git9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@pacoxu
Copy link
Member

pacoxu commented Jan 4, 2023

For kubeadm, the old taint node-role.kubernetes.io/master is not applied any more since v1.25, and we removed the toleration in v1.26.

Kubeadm: removed the toleration for the node-role.kubernetes.io/master taint from the CoreDNS deployment of kubeadm. With the 1.25 release of kubeadm the taint node-role.kubernetes.io/master is no longer applied to control plane nodes and the toleration for it can be removed with the release of 1.26. You can also perform the same toleration removal from your own addon manifests. (#112008

@bart0sh bart0sh moved this from Triage to PRs - Needs Approver in SIG Node CI/Test Board Jan 4, 2023
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Jan 4, 2023
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Jan 17, 2023
@kinzhi
Copy link
Member

kinzhi commented Feb 1, 2023

/hold cancel
/lgtm
/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit bb7c973 into kubernetes:master Feb 1, 2023
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@endocrimes endocrimes

@KnVerey KnVerey

@matthyx matthyx

@kinzhi kinzhi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@my-git9 @matthyx @k8s-ci-robot @pacoxu @KnVerey @endocrimes @kinzhi