Fix unknown field error in deployment lifecycle e2e #114873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terminationGracePeriodSeconds field was capitalized wrongly, leading to unknown field warning when running deployment lifecycle e2e: STEP: patching the Deployment @ 01/06/23 10:59:25.969 W0106 10:59:25.978292 433473 warnings.go:70] unknown field "spec.template.spec.TerminationGracePeriodSeconds" The issue was undiscovered because the patched value didn't change, so the test would succeed anyway. Signed-off-by: Quan Tian <qtian@vmware.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/test
sig/apps
|
/retest |
|
Nice catch. /triage accepted |
k8s-ci-robot
added
triage/accepted
|
@oomichi thanks for the review. It needs lgtm label to merge. Could you please add one, or should I request another reviewer? |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, oomichi, tnqn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: d6cf1ac32144aeb8eb344c3f69fb1417250a6544
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The terminationGracePeriodSeconds field was capitalized wrongly, leading to unknown field warning when running deployment lifecycle e2e:
The issue was undiscovered because the patched value didn't change, so the test would succeed anyway.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: