-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update publishing rules to use go1.19.5 #115029
Conversation
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
LGTM label has been added. Git tree hash: a6e75d9cfdc7de8adf99f6732243dd5ef77f3832
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Is this intended to be updated for all branches? If yes, we could just remove those lines because the default version is already 1.19.5 - kubernetes/staging/publishing/rules.yaml Line 2065 in 4802d7b
|
yes, all 1.23+ branches |
I think we only have 1.23+ here, however, we soon will have the main branch with go 1.20 so we might want to keep like this for now |
Good point. If we do take go1.20 back to release branches, we'd do that separately after getting more soak time and confidence on go1.20 |
👍 /hold cancel |
/test pull-kubernetes-unit |
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
/assign @nikhita @dims @liggitt @saschagrunert
cc @kubernetes/release-managers
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: