Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update publishing rules to use go1.19.5 #115029

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jan 12, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • update publishing rules to use go1.19.5

/assign @nikhita @dims @liggitt @saschagrunert
cc @kubernetes/release-managers

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

@cpanato: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 12, 2023
@dims
Copy link
Member

dims commented Jan 12, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6e75d9cfdc7de8adf99f6732243dd5ef77f3832

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@nikhita
Copy link
Member

nikhita commented Jan 12, 2023

/hold

Is this intended to be updated for all branches?

If yes, we could just remove those lines because the default version is already 1.19.5 -

default-go-version: 1.19.5

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@liggitt
Copy link
Member

liggitt commented Jan 12, 2023

If yes, we could just remove those lines because the default version is already 1.19.5 -

yes, all 1.23+ branches

@cpanato
Copy link
Member Author

cpanato commented Jan 12, 2023

/hold

Is this intended to be updated for all branches?

If yes, we could just remove those lines because the default version is already 1.19.5 -

default-go-version: 1.19.5

I think we only have 1.23+ here, however, we soon will have the main branch with go 1.20 so we might want to keep like this for now

@liggitt
Copy link
Member

liggitt commented Jan 12, 2023

I think we only have 1.23+ here, however, we soon will have the main branch with go 1.20 so we might want to keep like this for now

Good point. If we do take go1.20 back to release branches, we'd do that separately after getting more soak time and confidence on go1.20

@nikhita
Copy link
Member

nikhita commented Jan 12, 2023

I think we only have 1.23+ here, however, we soon will have the main branch with go 1.20 so we might want to keep like this for now

👍

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@cpanato
Copy link
Member Author

cpanato commented Jan 12, 2023

/test pull-kubernetes-unit

@liggitt
Copy link
Member

liggitt commented Jan 12, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit e3ae946 into kubernetes:master Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 12, 2023
@cpanato cpanato deleted the update-prombot branch January 13, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants