New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pause: remove obsolete Windows buildx workaround #115062
pause: remove obsolete Windows buildx workaround #115062
Conversation
Welcome @neersighted! |
Hi @neersighted. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The issue this workaround set out to address has been resolved in buildx for some time; there is no longer a need to preserve it. Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
d72ed32
to
31c7551
Compare
Seems reasonable |
/sig windows |
/assign @claudiubelu |
/triage accepted |
LGTM label has been added. Git tree hash: d20cd5156e105038f96d60bda4588c416b4d85b0
|
Let's see. According to the latest pause image build logs [1], the image being used for building is [1] https://storage.googleapis.com/kubernetes-jenkins/logs/post-kubernetes-push-image-pause/1601578642712825856/build-log.txt /lgtm |
/approve thanks @claudiubelu |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, neersighted The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/sig node
What this PR does / why we need it:
The issue this workaround set out to address has been resolved in buildx for some time (since v0.8.0); there is no longer a need to preserve it.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: