Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause: remove obsolete Windows buildx workaround #115062

Merged
merged 1 commit into from Jan 30, 2023

Conversation

neersighted
Copy link
Contributor

@neersighted neersighted commented Jan 13, 2023

What type of PR is this?

/kind cleanup
/sig node

What this PR does / why we need it:

The issue this workaround set out to address has been resolved in buildx for some time (since v0.8.0); there is no longer a need to preserve it.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 13, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: neersighted / name: Bjorn Neergaard (d72ed3257567a56b2d704373949b83625c479b62)

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @neersighted!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @neersighted. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 13, 2023
@neersighted neersighted changed the title pause: remove obsolete Windows BuildKit workaround pause: remove obsolete Windows buildx workaround Jan 13, 2023
The issue this workaround set out to address has been resolved in
buildx for some time; there is no longer a need to preserve it.

Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
@sftim
Copy link
Contributor

sftim commented Jan 16, 2023

Seems reasonable
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jan 17, 2023

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jan 17, 2023
@jsturtevant
Copy link
Contributor

/assign @claudiubelu

@bart0sh
Copy link
Contributor

bart0sh commented Jan 26, 2023

/triage accepted
/priority important-longterm
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 26, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 26, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d20cd5156e105038f96d60bda4588c416b4d85b0

@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Jan 26, 2023
@claudiubelu
Copy link
Contributor

Let's see. According to the latest pause image build logs [1], the image being used for building is gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20221007-69e0da97ef, which was published in 2022-10-07. This means that buildx-v0.8.0.linux-amd64 is used [2], as well as the moby/buildkit:buildx-stable-1 image which was updated recently. The issue was solved and tagged in [v0.8.0-rc1](https://github.com/moby/buildkit/releases/tag/v0.8.0-rc1), which means that this PR is safe.

[1] https://storage.googleapis.com/kubernetes-jenkins/logs/post-kubernetes-push-image-pause/1601578642712825856/build-log.txt
[2] https://github.com/kubernetes/test-infra/blob/ad65926f6bffc6ce858bc1aa8ba0fc775825b651/images/gcb-docker-gcloud/Dockerfile#L48
[3] moby/buildkit#1747

/lgtm

@dims
Copy link
Member

dims commented Jan 29, 2023

/approve

thanks @claudiubelu

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, neersighted

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit e205779 into kubernetes:master Jan 30, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 30, 2023
@neersighted neersighted deleted the drop_pause_workaround branch January 30, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants