managedfields: Move most of fieldmanager package to managefields #115065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
sig/api-machinery
apelisse
force-pushed
the
apimachinery-managed-fields
branch
from
f285e84
to
5728c4b
Compare
k8s-ci-robot
added
sig/auth
apelisse
force-pushed
the
apimachinery-managed-fields
branch
from
5728c4b
to
4c2936a
Compare
k8s-ci-robot
added
area/test
sig/testing
apelisse
force-pushed
the
apimachinery-managed-fields
branch
from
4c2936a
to
d74e49b
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
do-not-merge/work-in-progress
apelisse
force-pushed
the
apimachinery-managed-fields
branch
from
d74e49b
to
faf469d
Compare
k8s-ci-robot
added
size/XXL
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Feb 8, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Feb 9, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
soltysh
pushed a commit
to soltysh/kubernetes
that referenced
this pull request
Feb 9, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
soltysh
pushed a commit
to soltysh/kubernetes
that referenced
this pull request
Feb 12, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Feb 21, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Feb 21, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Feb 22, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Feb 27, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Feb 28, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Mar 1, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Mar 4, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Mar 4, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Mar 5, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
bertinatto
added a commit
to bertinatto/kubernetes
that referenced
this pull request
Mar 6, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
soltysh
pushed a commit
to soltysh/kubernetes
that referenced
this pull request
Mar 12, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Mar 27, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Mar 28, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
soltysh
pushed a commit
to soltysh/kubernetes
that referenced
this pull request
Apr 9, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 15, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 15, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 15, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 19, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 22, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 22, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 22, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 24, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
soltysh
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 24, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 25, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 26, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Apr 26, 2024
…util/managedfields Some of the code we use in openshift-tests was recently made internal in kubernetes#115065. This patch exposes the code we need there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move most of the fieldmanager package from
k8s.io/apiserver/pkg/endpoints/handler/fieldmanagertok8s.io/apimachinery/pkg/util/managedfieldswhere it'll be much easier to import in various parts of the system, including client-go which will be able to use it for test.This only moves code, and all references to the code. There is no behavior change. Except for the move, the gvkParser has been copied temporarily into the internal package to avoid the dependency cycle, but will have to be removed soon when the gvkParser is deprecated anyway (see #114439 which will contribute to that).
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?