Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new release of moby/ipvs #115079

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Update to new release of moby/ipvs #115079

merged 1 commit into from
Jan 15, 2023

Conversation

dims
Copy link
Member

@dims dims commented Jan 14, 2023 •
edited

hack/pin-dependency.sh github.com/moby/ipvs v1.1.0

Here's what got updated:

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

What this PR does / why we need it:

  • go to a fixed tag for vishvananda/netns
  • no more references to pkg/errors

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 14, 2023
@dims
Copy link
Member Author

dims commented Jan 14, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 14, 2023
@dims
Copy link
Member Author

dims commented Jan 14, 2023

/sig architecture
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 14, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2023
@dims
Copy link
Member Author

dims commented Jan 14, 2023

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 14, 2023
@dims
Update to new release of moby/ipvs
d9b98bc 
hack/pin-dependency.sh github.com/moby/ipvs v1.1.0

- go to a fixed tag for `vishvananda/netns`
- no more references to `pkg/errors`

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the update-to-newer-moby/ipvs-v1.1.0 branch from 8efb846 to d9b98bc Compare January 14, 2023 21:16
@dims
Copy link
Member Author

dims commented Jan 14, 2023

/test pull-kubernetes-e2e-kind-ipvs-dual-canary

@dims
Copy link
Member Author

dims commented Jan 14, 2023

/assign @liggitt

@dims
Copy link
Member Author

dims commented Jan 14, 2023

/test pull-kubernetes-e2e-gci-gce-ipvs

@aojea
Copy link
Member

aojea commented Jan 14, 2023

lgtm

@dims dims mentioned this pull request Jan 15, 2023
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu pacoxu mentioned this pull request Jan 15, 2023
Closed
15 tasks
@dims
Copy link
Member Author

dims commented Jan 15, 2023

@aojea needs a /lgtm :)

@aojea
Copy link
Member

aojea commented Jan 15, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14766485c8538619fd1d9e0607c15e069eaed840

@k8s-ci-robot k8s-ci-robot merged commit 3613ed0 into kubernetes:master Jan 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 15, 2023
@cici37
Copy link
Contributor

cici37 commented Jan 17, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dims @aojea @k8s-ci-robot @cici37 @pacoxu @liggitt