Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #115143: add custom dialer optimized for probes #115279

Merged
merged 4 commits into from Jan 30, 2023
Merged

Automated cherry pick of #115143: add custom dialer optimized for probes #115279

merged 4 commits into from Jan 30, 2023

Conversation

SergeyKanzhelev
Copy link
Member

Cherry pick of #115143 on release-1.25.

#115143: add custom dialer optimized for probes

For details on the cherry pick process, see the cherry pick requests page.

@aojea @SergeyKanzhelev
add custom dialer optimized for probes
99c3686 
probe util dial set linger to 1s
@aojea @SergeyKanzhelev
use custom dialer for tcp probes
fa7529e 
Change-Id: I323b472606eaf3242b665022afe2a79ecf3b8358
@aojea @SergeyKanzhelev
use custom dialer for http probes
4c84621
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 23, 2023
@SergeyKanzhelev
Copy link
Member Author

/triage accepted
/priority important-soon
/kind bug
/assign @aojea

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 23, 2023
@SergeyKanzhelev SergeyKanzhelev force-pushed the automated-cherry-pick-of-#115143-upstream-release-1.25 branch from 913494a to c057de5 Compare January 23, 2023 23:25
@SergeyKanzhelev
Copy link
Member Author

SergeyKanzhelev force-pushed the automated-cherry-pick-of-#115143-upstream-release-1.25 branch from 913494a to c057de5 now

I made it compile, but test fails locally. Need more changes

@SergeyKanzhelev
Copy link
Member Author

Fails with E0123 22:42:29.470013 3271924 prober.go:77] "Can't make a ref to pod and container" err="no kind is registered for the type v1.Pod in scheme \"k8s.io/kubernetes/pkg/api/legacyscheme/scheme.go:30\"" pod="testPod" containerName="cOnTaInEr_NaMe"

@aojea
Copy link
Member

aojea commented Jan 24, 2023

/retest

1 similar comment
@SergeyKanzhelev
Copy link
Member Author

/retest

@SergeyKanzhelev SergeyKanzhelev force-pushed the automated-cherry-pick-of-#115143-upstream-release-1.25 branch from c057de5 to b2a2cec Compare January 25, 2023 19:38
@aojea
Copy link
Member

aojea commented Jan 26, 2023

we should not backport b2a2cec9dd21feebefb72addf54fcc9b55236e6f , it flakes out of our CI

@aojea @SergeyKanzhelev
add scale test for probes
d33d8f8 
Change-Id: I1e49943531b569b5e02f82369750a9ca899ae726
@SergeyKanzhelev SergeyKanzhelev force-pushed the automated-cherry-pick-of-#115143-upstream-release-1.25 branch from b2a2cec to d33d8f8 Compare January 26, 2023 21:29
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Jan 26, 2023
@aojea
Copy link
Member

aojea commented Jan 26, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f8bae134a83ae7e6d4b111f504d5ab1bd48ef076

@SergeyKanzhelev
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@SergeyKanzhelev
Copy link
Member Author

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team January 27, 2023 17:19
@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jan 28, 2023
saschagrunert
saschagrunert approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit f6fb2e8 into kubernetes:release-1.25 Jan 30, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Jan 30, 2023
@SergeyKanzhelev SergeyKanzhelev deleted the automated-cherry-pick-of-#115143-upstream-release-1.25 branch January 30, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@saschagrunert saschagrunert

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SergeyKanzhelev @aojea @k8s-ci-robot @mrunalp @saschagrunert