Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass context to StartTestServer to get contextualized logger from it during tests #115298

Merged
merged 4 commits into from Jan 30, 2023
Merged

Pass context to StartTestServer to get contextualized logger from it during tests #115298

merged 4 commits into from Jan 30, 2023

Conversation

knelasevero
Copy link
Contributor

@knelasevero knelasevero commented Jan 24, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Changes needed before we go forward with #111155

Which issue(s) this PR fixes:

Special notes for your reviewer:

We need to pass context to StartTestServer to get contextualized logger from it during tests (in that other PR: #111155).

Does this PR introduce a user-facing change?

"NONE"

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 24, 2023
@knelasevero
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 24, 2023
@knelasevero knelasevero mentioned this pull request Jan 24, 2023
Closed
@alculquicondor
Copy link
Member

Please title this with the intention of the change, not what it enables

@knelasevero
Copy link
Contributor Author

/title Pass context to StartTestServer to get contextualized logger from it during tests

@knelasevero knelasevero changed the title Changes needed before #111155 Pass context to StartTestServer to get contextualized logger from it during tests Jan 24, 2023
VirrageS
VirrageS suggested changes Jan 24, 2023
View reviewed changes
staging/src/k8s.io/cloud-provider/app/testing/testserver.go Outdated Show resolved Hide resolved
test/integration/serving/serving_test.go Outdated Show resolved Hide resolved
cmd/kube-scheduler/app/testing/testserver.go Outdated Show resolved Hide resolved
staging/src/k8s.io/cloud-provider/app/testing/testserver.go Outdated Show resolved Hide resolved
@pohly
Copy link
Contributor

pohly commented Jan 24, 2023 •
edited

I think the same change is also in #114843

Nope, that's test/integration.

alculquicondor
alculquicondor reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@cici37
Copy link
Contributor

cici37 commented Jan 24, 2023

/remove-sig api-machinery
/wg contextual-logging

pohly
pohly reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 25, 2023
@knelasevero
Copy link
Contributor Author

/assign @mikedanese

@knelasevero
Copy link
Contributor Author

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 25, 2023
@knelasevero
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@knelasevero
Copy link
Contributor Author

/retest-required

@knelasevero
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-node-e2e-containerd

@knelasevero
Copy link
Contributor Author

A bunch of stuff failing on downdetector right now. I guess pull-kubernetes-e2e-gce and pull-kubernetes-node-e2e-containerd fails are related 🤔 I don't see why they would fail consistently with this PR otherwise

@knelasevero
Copy link
Contributor Author

/retest-required

@alculquicondor
Copy link
Member

/retest

2 similar comments
@knelasevero
Copy link
Contributor Author

/retest

@knelasevero
Copy link
Contributor Author

/retest

@knelasevero
Copy link
Contributor Author

@mikedanese can you please have a look? :)

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 26, 2023
@dims
Copy link
Member

dims commented Jan 30, 2023

Looks like this has ok's from @alculquicondor and @pohly, it lokos good to me as well.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dims, knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f529b56484a222f389dbfb600fecd486d5294ecd

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4b074c8 into kubernetes:master Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 30, 2023
@cici37
Copy link
Contributor

cici37 commented Jan 31, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@VirrageS VirrageS VirrageS requested changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@chendave chendave Awaiting requested review from chendave

Assignees

@dims dims

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@knelasevero @alculquicondor @pohly @cici37 @k8s-ci-robot @dims @VirrageS @mikedanese