New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd: Build image 3.5.7-0 #115336
etcd: Build image 3.5.7-0 #115336
Conversation
/test pull-kubernetes-unit |
@dims There's been some interesting changes in how etcd builds the official images. /lgtm |
LGTM label has been added. Git tree hash: cccae22487189edcb15bde8d9951b7d81d6d5b94
|
/lgtm |
/lgtm Are you talking about https://github.com/etcd-io/etcd/pull/15036/files#diff-2f60a4131f094ce9749a4e155ad2960ec62bbe04f0a1f33b0cbf3f7bf2d971c6R35 @hakman ? |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, mzaian, pacoxu, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dims Yes, that's the commit. The image seems pretty similar to the ones built from kubernetes/cluster/images/etcd/Dockerfile Lines 37 to 38 in 81df4d7
|
@hakman in our etcd image, we have a migration script that has helped us move between etcd versions just by updating to a new etcd container. We can open a fresh issue and vote on if we really need that anymore
@wojtek-t could we get rid of the migrate stuff? |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Build Image for v3.5.7.
Which issue(s) this PR fixes:
Fixes NONE #
Does this PR introduce a user-facing change?: