Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: Build image 3.5.7-0 #115336

Merged
merged 1 commit into from Jan 27, 2023
Merged

etcd: Build image 3.5.7-0 #115336

merged 1 commit into from Jan 27, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Jan 26, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Build Image for v3.5.7.

Which issue(s) this PR fixes:
Fixes NONE #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 26, 2023
@cici37
Copy link
Contributor

cici37 commented Jan 26, 2023

/test pull-kubernetes-unit
/assign @jpbetz
for etcd approval
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 26, 2023
@hakman
Copy link
Member

hakman commented Jan 27, 2023

@dims There's been some interesting changes in how etcd builds the official images.
The dependency on busybox has been removed in etcd-io/etcd#15036, which may allow just using the official images and adding another layer with the cp utility (is it still needed?).

/lgtm
/assign @dims
/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cccae22487189edcb15bde8d9951b7d81d6d5b94

@serathius
Copy link
Contributor

/lgtm
/approve

@dims
Copy link
Member

dims commented Jan 27, 2023

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Jan 27, 2023

/retest

@pacoxu
Copy link
Member

pacoxu commented Jan 27, 2023

/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mzaian, pacoxu, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member

hakman commented Jan 27, 2023

Are you talking about https://github.com/etcd-io/etcd/pull/15036/files#diff-2f60a4131f094ce9749a4e155ad2960ec62bbe04f0a1f33b0cbf3f7bf2d971c6R35 @hakman ?

@dims Yes, that's the commit. The image seems pretty similar to the ones built from cluster/images/etcd/Dockerfile, except for a few extra files:

COPY cp* /bin/
COPY migrate-if-needed.sh migrate /usr/local/bin/

@k8s-ci-robot k8s-ci-robot merged commit 5a2dd64 into kubernetes:master Jan 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 27, 2023
@dims
Copy link
Member

dims commented Jan 27, 2023

@hakman in our etcd image, we have a migration script that has helped us move between etcd versions just by updating to a new etcd container. We can open a fresh issue and vote on if we really need that anymore

@wojtek-t could we get rid of the migrate stuff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants