client-go: don't wait too long after EventBroadcaster.Shutdown

[pohly]

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:

When Shutdown was called, delivery of each pending event would still be retried 12 times with a delay of ~10s between each retry. In apiserver integration tests that caused the goroutine to linger long after the corresponding apiserver of the test was shut down.

Special notes for your reviewer:

These goroutine can be seen in go test -run='TestQuota$' ./test/integration/quota/ by setting a breakpoint in EtcdMain.

The leaked goroutines there come from this code:

kubernetes/pkg/controller/replicaset/replica_set.go

Lines 189 to 196 in 49ddc51

	// Run begins watching and syncing.
	func (rsc *ReplicaSetController) Run(ctx context.Context, workers int) {
	defer utilruntime.HandleCrash()
	// Start events processing pipeline.
	rsc.eventBroadcaster.StartStructuredLogging(0)
	rsc.eventBroadcaster.StartRecordingToSink(&v1core.EventSinkImpl{Interface: rsc.kubeClient.CoreV1().Events("")})
	defer rsc.eventBroadcaster.Shutdown()

Does this PR introduce a user-facing change?

To be decided... empty for now as a reminder.

k8s.io/client-go/tools/record.EventBroadcaster: after Shutdown() is called, the broadcaster now gives up immediately after a failure to write an event to a sink. Previously it tried multiple times for 12 seconds in a goroutine.

/cc @aojea

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[aojea]

/lgtm
/assign @wojtek-t

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1ca310b6969851ee8ad1e018306663a4fd74f24a

[cici37]

/triage accepted

[wojtek-t]

/lgtm
/approve

/priority important-longterm

@pohly - thanks for making the change - can you please update the release-note?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/client-go/tools/record/OWNERS [wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment