Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherrypick #115537][1.25]*: Bump golangci-lint version and adapt to new linters #115608

Merged
merged 2 commits into from Feb 9, 2023
Merged

[Cherrypick #115537][1.25]*: Bump golangci-lint version and adapt to new linters #115608

merged 2 commits into from Feb 9, 2023

Conversation

MadhavJivrajani
Copy link
Contributor

What type of PR is this?

Cherry-pick of #115537

/kind cleanup
/sig testing
/priority backlog

What this PR does / why we need it:

Bump golangci-lint version. This version
adds support for go1.20.

This consequently also bumps the version of
staticcheck. Note that this was changed to
use master to be compatible with 1.20(#115129). This
commit reverts back to using a tagged release.

golangci-lint release: https://github.com/golangci/golangci-lint/releases/tag/v1.51.1
staticcheck release: https://github.com/dominikh/go-tools/releases/tag/2023.1

Which issue(s) this PR fixes:

Fixes #
NA

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @liggitt @dims

@MadhavJivrajani
hack/tools: Bump golangci-lint version
d5e6674 
Bump golangci-lint version. This version
adds support for go1.20.

This consequently also bumps the version of
staticcheck. Note that this was changed to
use master to be compatible with 1.20. This
commit reverts back to using a tagged release.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani
*: Fix linter warnings
e1d6920 
Adapt to newly improved linters in golangci-lint v1.51.1

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Feb 8, 2023
@k8s-ci-robot k8s-ci-robot requested review from coffeepac, pohly and a team February 8, 2023 06:09
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Feb 8, 2023
@MadhavJivrajani MadhavJivrajani mentioned this pull request Feb 8, 2023
Merged
@dims
Copy link
Member

dims commented Feb 8, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 575665a2d056c1f3a69bdf46a81c37aa85d5630e

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@liggitt liggitt mentioned this pull request Feb 8, 2023
Closed
34 tasks
@liggitt
Copy link
Member

liggitt commented Feb 8, 2023

/lgtm
/approve
/priority important-longterm
/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team February 8, 2023 17:11
@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 8, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Done in SIG Node CI/Test Board Feb 8, 2023
@ameukam
Copy link
Member

ameukam commented Feb 9, 2023

cc https://github.com/orgs/kubernetes/teams/release-managers

@cpanato
Copy link
Member

cpanato commented Feb 9, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2023
cpanato
cpanato approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

SIG Node CI/Test Board automation moved this from Done to PRs - Needs Approver Feb 9, 2023
@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, liggitt, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8e1dc38 into kubernetes:release-1.25 Feb 9, 2023
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@coffeepac coffeepac Awaiting requested review from coffeepac

@pohly pohly Awaiting requested review from pohly

Assignees

@dims dims

@liggitt liggitt

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MadhavJivrajani @dims @k8s-ci-robot @liggitt @ameukam @cpanato