New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document risk of HTTP response body in probe failure msg #115670
Conversation
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 8723319a12f332432c28c2346ea56dbe5764c6e7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
It would be useful to have access to the HTTP response body for debugging HTTP probe failures, but unfortunately this would be a security problem due to #99425.
We get PRs with some frequency trying to make this change (e.g. #113447, #108918), so we should document the risk inline.
Which issue(s) this PR fixes:
For #99425
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/assign @aojea