Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert #114605: its unit test requires root permission" #115769

Merged
merged 3 commits into from Mar 8, 2023
Merged

Revert "Revert #114605: its unit test requires root permission" #115769

merged 3 commits into from Mar 8, 2023
+73 −30

Conversation

mochizuki875
Copy link
Member

@mochizuki875 mochizuki875 commented Feb 14, 2023 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Removed unit test which requires root permissions to run.
Reverts kubernetes/kubernetes #115732
Original PR #114605

Which issue(s) this PR fixes:

Fixes #114546

Does this PR introduce a user-facing change?

Fix the problem Pod terminating stuck because of trying to umount not actual mounted dir.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mochizuki875. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 14, 2023
@mochizuki875 mochizuki875 changed the title [WIP] Revert "Revert #114605: its unit test requires root permission" Revert "Revert #114605: its unit test requires root permission" Feb 15, 2023
@mochizuki875 mochizuki875 marked this pull request as ready for review February 15, 2023 13:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023
@mochizuki875
Copy link
Member Author

mochizuki875 commented Feb 15, 2023 •
edited

/assign @jsafrane
/assign @liggitt

@mochizuki875
Copy link
Member Author

@jsafrane @liggitt
Revert #115732 and removed the case that breaks running unit tests without superuser mode.
Could you please check again?

@mochizuki875 mochizuki875 mentioned this pull request Feb 15, 2023
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2023
@gnufied
Copy link
Member

gnufied commented Feb 16, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2023
@mochizuki875
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 1, 2023
@mochizuki875
Copy link
Member Author

Since the original PR #114605 is priority/important-soon, is this PR also priority/important-soon?
This PR includes the bug fix which may cause Pod terminating stuck( #114605 ).

@mochizuki875
Copy link
Member Author

/cc @jsafrane

@bart0sh
Copy link
Contributor

bart0sh commented Mar 2, 2023

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Mar 2, 2023
@mochizuki875
Copy link
Member Author

@jsafrane PTAL?
#115769 (comment)

@jsafrane
Copy link
Member

jsafrane commented Mar 8, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: baae3a8d5bde7f736e45adcabdb90b5385ff2054

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mochizuki875

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@mochizuki875
Copy link
Member Author

/retest

1 similar comment
@mochizuki875
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 713ded7 into kubernetes:master Mar 8, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 8, 2023
@dlipovetsky dlipovetsky mentioned this pull request Apr 6, 2023
Merged
@mochizuki875 mochizuki875 deleted the revert-115732-revert-root-test branch May 26, 2023 07:57
This was referenced Aug 8, 2023
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 6, 2023
@k8s-ci-robot
Merge pull request #119831 from cartermckinnon/automated-cherry-pick-…
e3acaa0 
…of-#115769-upstream-release-1.26

Automated cherry pick of #115769: Revert "Revert #114605: its unit test requires root
k8s-ci-robot added a commit that referenced this pull request Sep 6, 2023
@k8s-ci-robot
Merge pull request #119832 from cartermckinnon/automated-cherry-pick-…
b0c8aa0 
…of-#115769-upstream-release-1.25

Automated cherry pick of #115769: Revert "Revert #114605: its unit test requires root
@mochizuki875 mochizuki875 mentioned this pull request Nov 24, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@gnufied gnufied Awaiting requested review from gnufied

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@msau42 msau42 Awaiting requested review from msau42

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@liggitt liggitt

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

Pod terminating stuck because of trying to umount not actual mounted dir
6 participants
@mochizuki875 @k8s-ci-robot @gnufied @bart0sh @jsafrane @liggitt