storage: Get rid of TestListDeprecated #115794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Int64Ptr is now deprecated. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/cleanup
wojtek-t
reviewed
Feb 21, 2023
There was a problem hiding this comment.
@MadhavJivrajani - Thanks for working on it - addded some comments.
staging/src/k8s.io/apiserver/pkg/storage/testing/store_tests.go
Outdated
Show resolved
Hide resolved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
MadhavJivrajani
force-pushed
the
remove-test-list-deprecated
branch
from
40f4da1
to
159dce6
Compare
wojtek-t
reviewed
Feb 22, 2023
staging/src/k8s.io/apiserver/pkg/storage/testing/store_tests.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/testing/store_tests.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/testing/store_tests.go
Outdated
Show resolved
Hide resolved
MadhavJivrajani
force-pushed
the
remove-test-list-deprecated
branch
from
159dce6
to
56a02cd
Compare
|
@wojtek-t addressed both comments, PTAL, thanks! |
MadhavJivrajani
force-pushed
the
remove-test-list-deprecated
branch
from
56a02cd
to
c9a6171
Compare
wojtek-t
reviewed
Feb 23, 2023
staging/src/k8s.io/apiserver/pkg/storage/testing/store_tests.go
Outdated
Show resolved
Hide resolved
This commit extends the test cases of RunTestList to include the things tested by TestListDeprecated and subsequently deletes the test. This additionally adds a test case for checking that the list return the modified version of an object. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
MadhavJivrajani
force-pushed
the
remove-test-list-deprecated
branch
from
c9a6171
to
7474d9b
Compare
|
Thanks for review @wojtek-t 🙏🏼 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1905db3e782c615f1db0617522594531b4f6acd8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MadhavJivrajani, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Commit 1: minor cleanup for using deprecated functions
Commit 2:
This commit extends the test cases of RunTestList
to include the things tested by TestListDeprecated
and subsequently deletes the test.
This additionally adds a test case for checking that
the list return the modified version of an object.
Which issue(s) this PR fixes:
Towards #109831
Special notes for your reviewer:
Commit 2 contains the actual cleanup
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @wojtek-t
/sig api-machinery
/priority backlog