Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch image in gRPC probe tests to agnhost #115800

Merged
merged 3 commits into from Feb 18, 2023
Merged

Switch image in gRPC probe tests to agnhost #115800

merged 3 commits into from Feb 18, 2023

Conversation

shogohida
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Changes etcd image to agnhost image

Which issue(s) this PR fixes:

Fixes #115781

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@shogohida
Change etcd to agnhost
58ae449 
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @shogohida!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @shogohida. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2023
@bart0sh bart0sh added this to WIP in SIG Node PR Triage Feb 16, 2023
@shogohida shogohida marked this pull request as ready for review February 17, 2023 00:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
SergeyKanzhelev
SergeyKanzhelev reviewed Feb 17, 2023
View reviewed changes
test/e2e/common/node/container_probe.go Outdated
Command: []string{
"/usr/local/bin/etcd",
"/usr/local/bin/agnhost",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work. Have you tried it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this article you can find out how the arguments would look like for the agnhost: https://kubernetes.io/blog/2022/05/13/grpc-probes-now-in-beta/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyKanzhelev
Thanks for your review! I fixed the code so please check it!

@shogohida
Fix arguments
26f95f4 
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
shogohida
shogohida commented Feb 18, 2023
View reviewed changes
test/e2e/common/node/container_probe.go
@@ -630,7 +629,7 @@ done
podClient := e2epod.NewPodClient(f)
terminationGracePeriod := int64(30)
script := `
_term() {
_term() {
Copy link
Contributor Author

@shogohida shogohida Feb 18, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space was deleted automatically by Visual Studio Code.

shogohida
shogohida commented Feb 18, 2023
View reviewed changes
test/e2e/common/node/container_probe.go
@@ -641,7 +640,7 @@ trap _term SIGTERM
touch /tmp/ready
touch /tmp/liveness

while true; do
while true; do
Copy link
Contributor Author

@shogohida shogohida Feb 18, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank space was deleted automatically by Visual Studio Code.

SergeyKanzhelev
SergeyKanzhelev reviewed Feb 18, 2023
View reviewed changes
test/e2e/common/node/container_probe.go
@@ -534,7 +533,7 @@ var _ = SIGDescribe("Probing container", func() {
FailureThreshold: 1,
}

pod := gRPCServerPodSpec(nil, livenessProbe, "etcd")
pod := gRPCServerPodSpec(nil, livenessProbe, "agnhost")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you run the test? You still hasn;t updated the port in liveness probe definition on the line 527

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry about that. I changed it to 5000

@shogohida
Fix port number
7cbf007 
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 18, 2023
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 18, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, shogohida

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c09ab35f0a3d01295af4a517dc5d0ec97e528ab6

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from WIP to Needs Approver in SIG Node PR Triage Feb 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit d6fe718 into kubernetes:master Feb 18, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Feb 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 18, 2023
@shogohida shogohida deleted the switch-image-in-grpc-probe-tests-to-agnhost branch February 18, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@endocrimes endocrimes Awaiting requested review from endocrimes

@odinuge odinuge Awaiting requested review from odinuge

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

Switch image in gRPC probe tests to agnhost
3 participants
@shogohida @k8s-ci-robot @SergeyKanzhelev