Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add log artifact for ginkgo node e2e and tune default ginkgo flags #116057

Merged
merged 3 commits into from Mar 2, 2023
Merged

test: Add log artifact for ginkgo node e2e and tune default ginkgo flags #116057

merged 3 commits into from Mar 2, 2023

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Feb 25, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR makes a few updates to the node e2e runner to make debugging the tests easier. Please review commit by commit.

The main changes are:

  1. Emit a ginkgo log for each node. Currently when a node e2e image config has multiple images defined, the test is run in parallel for each image, and the results are all concatenated into a huge log file. Searching this log file becomes difficult, as some pod names/other artifacts are re-used across the tests on different hosts. As a result, to make debugging simpler, emit a log file for each node that contains just the ginkgo log that was run on that node.
  2. Add some defaults flags for ginkgo. Specifically, --no-color to disable color as it makes examining the logs harder in prow and in text editors, and -v to enable verbose logs, so even if tests pass we receive the test output. This is helpful to compare passing runs to failed runs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 25, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2023
@bobbypage bobbypage force-pushed the nodee2elog branch 4 times, most recently from cc99e11 to 7b56374 Compare February 25, 2023 22:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2023
@bobbypage bobbypage force-pushed the nodee2elog branch 3 times, most recently from f2bd0be to af5c2fc Compare February 26, 2023 03:15
@bobbypage
Copy link
Member Author

/pull pull-kubernetes-node-kubelet-serial-containerd

@bobbypage
Copy link
Member Author

/test pull-kubernetes-node-kubelet-serial-containerd

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 28, 2023
@bobbypage bobbypage changed the title WIP: Add node specific build log test: Add log artifact for ginkgo node e2e and tune default ginkgo flags Feb 28, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
@bobbypage bobbypage mentioned this pull request Feb 28, 2023
Closed
@bart0sh
Copy link
Contributor

bart0sh commented Feb 28, 2023

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 28, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Feb 28, 2023

/triage accepted
/priority important-longterm
/assign @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2023
@bart0sh bart0sh added this to Needs Reviewer in SIG Node PR Triage Feb 28, 2023
@SergeyKanzhelev
Copy link
Member

/assign @xmcqueen

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Mar 1, 2023
SergeyKanzhelev
SergeyKanzhelev reviewed Mar 1, 2023
View reviewed changes
test/e2e_node/runner/remote/run_remote.go
@@ -359,7 +361,6 @@ func prepareGceImages() (*internalImageConfig, error) {
metadata: getImageMetadata(metadata),
kernelArguments: imageConfig.KernelArguments,
machine: imageConfig.Machine,
tests: imageConfig.Tests,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for removing this. Did you check we removed all the instances of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the only reference I could find is kubernetes/test-infra#26017 but it was deleted in that PR.

SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xmcqueen sorry for stepping into your review. This change lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57bde7260b4b3bf73a8cba057e70a5f5e78f11d1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1646ed8 into kubernetes:master Mar 2, 2023
SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Mar 2, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@SergeyKanzhelev SergeyKanzhelev

@xmcqueen xmcqueen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bobbypage @k8s-ci-robot @bart0sh @SergeyKanzhelev @xmcqueen