Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll for stats until Windows kubelet present it in the stats endpoint #116110

Merged
merged 1 commit into from Mar 1, 2023
Merged

Poll for stats until Windows kubelet present it in the stats endpoint #116110

merged 1 commit into from Mar 1, 2023

Conversation

knabben
Copy link
Member

@knabben knabben commented Feb 27, 2023

What type of PR is this?

/kind flake
/kind failing-test
/sig windows

What this PR does / why we need it:

Polling the Kubelet stats endpoint until a CPU/Mem value appears for the pod, or fail close.

Which issue(s) this PR fixes:

Fixes #115932

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 27, 2023
@knabben
Copy link
Member Author

knabben commented Feb 27, 2023

cc @jsturtevant

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 27, 2023
@knabben
Copy link
Member Author

knabben commented Feb 28, 2023 •
edited

/test pull-kubernetes-e2e-capz-windows-containerd

startup failure

1 similar comment
@knabben
Copy link
Member Author

knabben commented Feb 28, 2023 •
edited

/test pull-kubernetes-e2e-capz-windows-containerd

startup failure

@knabben
Copy link
Member Author

knabben commented Feb 28, 2023 •
edited

/test pull-kubernetes-e2e-capz-windows-containerd

ServiceAccounts ServiceAccountIssuerDiscovery should support OIDC discovery of service account issuer flake

@knabben
Copy link
Member Author

knabben commented Feb 28, 2023

/test pull-kubernetes-e2e-capz-windows-containerd

1 similar comment
@knabben
Copy link
Member Author

knabben commented Feb 28, 2023

/test pull-kubernetes-e2e-capz-windows-containerd

@jsturtevant
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 28, 2023
jsturtevant
jsturtevant reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm generally, one minor suggest for readability. Due to the infrequency of this flake, we will have to merge and monitor.

test/e2e/windows/host_process.go Outdated

for _, containerStats := range podStats.Containers {
statsChecked = true
for _, podStats := range nodeStats.Pods {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we move this validation to a function? It might make reading this easier.

@knabben knabben force-pushed the knabben/polling-hpc-stats branch 2 times, most recently from 0f207f7 to 677d849 Compare March 1, 2023 19:32
@jsturtevant
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 739a05b3cc707ba6a1ddf9f9cf8724365b41d40a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, knabben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit dfa0323 into kubernetes:master Mar 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 1, 2023
@knabben knabben deleted the knabben/polling-hpc-stats branch March 2, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@jsturtevant jsturtevant

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

[Flaky] HostProcess containers container stats validation
3 participants
@knabben @jsturtevant @k8s-ci-robot