delete Evicted pods first during pod gc

[borgerli]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When gc-ing pods, kcm only cares about creation time and pod name. In a cluster with losts of Evicted pods and otehr kind of terminated pods, such as created by job controllers, controller-created pods may be deleted first, which will impact on controller behaviours.
With this PR, Evicted pods will be deleted first, and try to avoid delete other terminated pods as best as possible.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

When GCing pods, kube-controller-manager will delete Evicted pods first.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @borgerli. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

@wojtek-t who may own this?

[wojtek-t]

I have one small comment - other than that LGTM.

[wojtek-t]

This is technically correct now, but I think there is a potential for breakage in the future is PodIsEvicted function changes in the future (for whatever reason).

So I would feel more comfortable with:

iEvicted, jEvicted := eviction.PodIsEvicted(o[i].Status), eviction.PodIsEvicted(o[j].Status)
if iEvicted != jEvicted {
  // If only on of pods is evicted, i is smaller if it is evicted.
  return iEvicted
}

if iEvicted, jEvicted := eviction.PodIsEvicted(o[i].Status), evic

[borgerli]

@wojtek-t Thanks for the great point. I updated code as suggested.

[wojtek-t]

/ok-to-test

[wojtek-t]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 714278316464c616bcf529f3e502237aeb9a963c

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: borgerli, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment