Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start to count time since the connection was actually established #116176

Merged
merged 1 commit into from Mar 1, 2023
Merged

start to count time since the connection was actually established #116176

merged 1 commit into from Mar 1, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Mar 1, 2023

/kind flake

NONE

The time to start pings should account the time needed to create the connection, hence, we should start counting AFTER the connection has. been established

Fixes: #116165

@aojea
start to count time since the connection was actually established
d6f81c0 
Change-Id: Ib4986fb362600b760a4a853513d739f2d665836e
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 1, 2023
@aojea
Copy link
Member Author

aojea commented Mar 1, 2023

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 1, 2023
@aojea aojea mentioned this pull request Mar 1, 2023
Closed
aojea
aojea commented Mar 1, 2023
View reviewed changes
staging/src/k8s.io/apimachinery/pkg/util/httpstream/spdy/connection_test.go
clSPDYConn, err := NewClientConnection(clConn)
if err != nil {
t.Fatalf("client: error creating spdy connection: %v", err)
}
defer clSPDYConn.Close()
start := time.Now()
Copy link
Member Author

@aojea aojea Mar 1, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see line 278, it uses this time to define a period where we can count the number of pings, but if the connection takes more than 3*pingPeriod to be established, then this test will fail

@aojea
Copy link
Member Author

aojea commented Mar 1, 2023

/assign @lavalamp

@liggitt
Copy link
Member

liggitt commented Mar 1, 2023

looks plausible... was the flake reproducible with stress before and fixed with this change?

@aojea
Copy link
Member Author

aojea commented Mar 1, 2023

looks plausible... was the flake reproducible with stress before and fixed with this change?

couldn't reproduce the flake locally

@liggitt
Copy link
Member

liggitt commented Mar 1, 2023

ok

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d9578f556e4423a3bf269fbf1982ae64feb9cf2d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 44bedc2 into kubernetes:master Mar 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 1, 2023
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@lavalamp lavalamp

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

TestConnectionPings: server: failed to send any pings (check logs)
5 participants
@aojea @liggitt @k8s-ci-robot @fedebongio @lavalamp