Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove retention policy for staging buckets #116222

Merged
merged 1 commit into from Mar 2, 2023
Merged

remove retention policy for staging buckets #116222

merged 1 commit into from Mar 2, 2023

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Mar 2, 2023 •
edited by liggitt

Follow-up of:

The current retention policy prevent creation or update of new objects until the existing one are deleted based on the retention period.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 2, 2023
@liggitt
Copy link
Member

liggitt commented Mar 2, 2023

/lgtm
/approve
/kind failing-test
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 23dc5d9214c15bb6d12d3b657c7e52991499d13c

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 2, 2023
@ameukam
Copy link
Member Author

ameukam commented Mar 2, 2023

Any new bucket should be created without retention policy.

@liggitt
Copy link
Member

liggitt commented Mar 2, 2023 •
edited

cc @wojtek-t @aojea "storage/cacher: Test_newReadyRacy" failed in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/116222/pull-kubernetes-unit/1631324028675297280

opened #116225 to track

/retest

@ameukam
Copy link
Member Author

ameukam commented Mar 2, 2023

/retest

@aojea
Copy link
Member

aojea commented Mar 2, 2023

👀

@BenTheElder BenTheElder mentioned this pull request Mar 2, 2023
Closed
@BenTheElder
Copy link
Member

#116197 (comment)

when we circle back to this we will want to set a lifecycle policy (TTL rule) instead of retention policy (forced to keep) 😅

@BenTheElder
Copy link
Member

Real verify failure:

In ./cluster/gce/util.sh line 329:
    retention_period="1d" # https://cloud.google.com/storage/docs/bucket-lock#retention-periods
    ^--------------^ SC2034 (warning): retention_period appears unused. Verify use (or export if used externally).

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/116222/pull-kubernetes-verify/1631339053372674048

Recommend adding a gsutil retention clear while fixing this.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@ameukam
remove retention policy for staging buckets
4719855 
Follow-up of:
  - kubernetes#115634

The current retention policy prevent creation or update of new objects
until the existing one are deleted based on the retention period.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
BenTheElder
BenTheElder reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3152f32f8480bc78853456c6cbcb5fd48cbf5ca7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 2, 2023
@ameukam
Copy link
Member Author

ameukam commented Mar 2, 2023

/retest

@ameukam ameukam mentioned this pull request Mar 2, 2023
Open
@ameukam
Copy link
Member Author

ameukam commented Mar 2, 2023

/retest

2 similar comments
@liggitt
Copy link
Member

liggitt commented Mar 2, 2023

/retest

@liggitt
Copy link
Member

liggitt commented Mar 2, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit a80b423 into kubernetes:master Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 2, 2023
This was referenced Mar 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@bowei bowei Awaiting requested review from bowei

@cjcullen cjcullen Awaiting requested review from cjcullen

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@BenTheElder BenTheElder

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ameukam @liggitt @k8s-ci-robot @aojea @BenTheElder @dims