Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belatedly remove controller-manager IPv6DualStack feature gate #116255

Merged

Conversation

danwinship
Copy link
Contributor

@danwinship danwinship commented Mar 3, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

controller-manager still had an IPv6DualStack feature gate, which cloud-provider still checked. This feature went GA in 1.23.

Does this PR introduce a user-facing change?

The `IPv6DualStack` feature gate for external cloud providers was removed.
(The feature became GA in 1.23 and the gate was removed for all other
components several releases ago.) Action required: If you were still manually
enabling it you must stop now.

/cc @khenidak

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2023
@danwinship
Copy link
Contributor Author

/sig network
/auto-cc

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Mar 3, 2023
@danwinship danwinship force-pushed the controller-manager-ipv6dualstack branch from 5c5d5f6 to 3181db4 Compare March 3, 2023 18:16
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 3, 2023
@aojea
Copy link
Member

aojea commented Mar 4, 2023

/lgtm
/assign @thockin @andrewsykim

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f70ef2cf9ce40fc7ced95a1ed5e3ec9b5f19a077

@liggitt
Copy link
Member

liggitt commented Mar 6, 2023

/lgtm
/approve

needs an action-required release note that the feature gate is removed, and open a PR to the dev-1.27 branch of the website to adjust https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/ and https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
//
// Enables ipv6 dual stack
// Original copy from k8s.io/kubernetes/pkg/features/kube_features.go
IPv6DualStack featuregate.Feature = "IPv6DualStack"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 6, 2023
@danwinship
Copy link
Contributor Author

needs an action-required release note that the feature gate is removed

done

and open a PR to the dev-1.27 branch of the website to adjust https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/ and https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

I guess I didn't say this explicitly above, but the feature gate existed in several other components as well but was already removed. So it's already listed on the "feature-gates-removed" page, and not listed on the "feature-gates" page. There doesn't seem to be any precedent there about gates removed from different components at different times. (Since, obviously, that's not supposed to happen...) But it seems reasonable to just pretend it was removed everywhere in 1.25? No one is likely to be hurt by that...

@liggitt
Copy link
Member

liggitt commented Mar 6, 2023

ah, I missed this was a secondary cleanup of an already removed gate... yeah... this seems fine

@k8s-ci-robot k8s-ci-robot merged commit ff27ccf into kubernetes:master Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 6, 2023
@danwinship danwinship deleted the controller-manager-ipv6dualstack branch March 6, 2023 17:27
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants