New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Belatedly remove controller-manager IPv6DualStack feature gate #116255
Belatedly remove controller-manager IPv6DualStack feature gate #116255
Conversation
/sig network |
5c5d5f6
to
3181db4
Compare
/lgtm |
LGTM label has been added. Git tree hash: f70ef2cf9ce40fc7ced95a1ed5e3ec9b5f19a077
|
/lgtm needs an action-required release note that the feature gate is removed, and open a PR to the dev-1.27 branch of the website to adjust https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/ and https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// | ||
// Enables ipv6 dual stack | ||
// Original copy from k8s.io/kubernetes/pkg/features/kube_features.go | ||
IPv6DualStack featuregate.Feature = "IPv6DualStack" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: #115204 (comment)
done
I guess I didn't say this explicitly above, but the feature gate existed in several other components as well but was already removed. So it's already listed on the "feature-gates-removed" page, and not listed on the "feature-gates" page. There doesn't seem to be any precedent there about gates removed from different components at different times. (Since, obviously, that's not supposed to happen...) But it seems reasonable to just pretend it was removed everywhere in 1.25? No one is likely to be hurt by that... |
ah, I missed this was a secondary cleanup of an already removed gate... yeah... this seems fine |
/triage accepted |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
controller-manager still had an
IPv6DualStack
feature gate, which cloud-provider still checked. This feature went GA in 1.23.Does this PR introduce a user-facing change?
/cc @khenidak