Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused resize.go from pkg/kubelet/container #116296

Merged
merged 1 commit into from Mar 10, 2023
Merged

Remove unused resize.go from pkg/kubelet/container #116296

merged 1 commit into from Mar 10, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Mar 6, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Since docker and rkt was removed from kubelet, HandleResizing is unused and can be removed.
Examples of how it was used before https://github.com/kubernetes/kubernetes/pull/41543/files#diff-39d88889239883999e8922974bd9e50736b45f8acf5cde05d3298e51c43f2311

Which issue(s) this PR fixes:

Ref #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 6, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Mar 7, 2023

/assign @klueska

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Mar 7, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Mar 7, 2023

/triage accepted
/priority important-longterm
/lgtm
/assign @bart0sh @SergeyKanzhelev @mrunalp

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 95de363077121f50d65a15bce2c04ddcea392b2c

@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Mar 7, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@klueska
Copy link
Contributor

klueska commented Mar 9, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, SataQiu, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3219564 into kubernetes:master Mar 10, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@mrunalp mrunalp

@klueska klueska

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SataQiu @bart0sh @k8s-ci-robot @klueska @SergeyKanzhelev @mrunalp