-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/verify-mocks.sh Append sudo
to a git worktree remove
command
#116338
Comments
There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:
Please see the group list for a listing of the SIGs, working groups, and committees available. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @samruddhikhandale could I take this up? Sounds like a small enough issue. |
I don't think we should be adding |
Closing as no longer needed! Thanks. |
I had the same error locally from my mac. The problem is when trying to remove the worktree from /private. See this example:
Running hack/verify-mocks.sh again... The worktree has been removed BUT the temp dir is still there
|
What happened?
Hi 馃憢
I have been working with @craiglpeters on adding a dev container to this repo - #113019
With the dev config, when we run
make verify
then, we are having a test failure forhack/verify-mocks.sh
. It fails at this line with following error msg 馃憞The dev config uses a
vscode
remote user, I wonder if that's the cause of this test failure.What did you expect to happen?
I expect
make verify
to succeed with the dev config. Hence, can we update the current hack/verify-mocks.sh file and appendsudo
to it ? This fixes the testCurrent -
Proposed -
How can we reproduce it (as minimally and precisely as possible)?
N/A
Anything else we need to know?
No response
Kubernetes version
N/A
Cloud provider
N/A
OS version
Install tools
Container runtime (CRI) and version (if applicable)
Related plugins (CNI, CSI, ...) and versions (if applicable)
The text was updated successfully, but these errors were encountered: