Unlock CSIMigrationvSphere feature gate #116342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
|
/assign @xing-yang @divyenpatel |
xing-yang
reviewed
Mar 7, 2023
pkg/features/kube_features.go
Outdated
| @@ -896,7 +896,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS | |||
|
|
|||
| CSIMigrationRBD: {Default: false, PreRelease: featuregate.Alpha}, // Off by default (requires RBD CSI driver) | |||
|
|
|||
| CSIMigrationvSphere: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.28 | |||
| CSIMigrationvSphere: {Default: true, PreRelease: featuregate.GA}, // LockToDefault when supported CSI driver is available | |||
There was a problem hiding this comment.
Can you clarify what is a supported CSI driver, i.e., raw block, windows, xfs should be GA in CSI driver
…phere CSI driver available
|
Can you also update the release notes with those details |
|
Done |
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0d52f79fde7b0faffd226270d1b0dabf19c1293c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
/retest |
|
#116364 flake |
|
/retest |
|
Changelog suggestion: -Unlock the CSIMigrationvSphere feature gate to allow users to wait for a vSphere CSI driver version with GA support for Windows, raw block and xfs features.
+Unlocked the `CSIMigrationvSphere` feature gate.
+The change allow users to continue using the in-tree vSphere driver,pending a vSphere
+CSI driver release that has with GA support for Windows, XFS, and raw block access. |
|
Thanks updated |
elmiko
added a commit
to elmiko/library-go
that referenced
this pull request
Mar 22, 2023
Due to changes in upstream kubernetes, the vSphere in-tree cloud provider will need to be used in situations where the in-tree storage is still in use. Because OpenShift 4.13 is enabling CSI migration by default for vSphere, there will need to be a regression method for the CCM as well. This change transforms the IsCloudProviderExternal function to detect this condition. references: https://groups.google.com/g/kubernetes-sig-storage/c/wvJpNDBS9vU kubernetes/kubernetes#116342 https://issues.redhat.com/browse/STOR-1265
|
We have identified an issue with migration - kubernetes-sigs/vsphere-csi-driver#2165 which is a potential blocker. The issue has no known fix and as far as I can tell no known workaround. |
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 3, 2023
…42-upstream-release-1.26 Automated cherry pick of #116342: Unlock CSIMigrationvSphere feature gate
sebsoto
added a commit
to sebsoto/windows-machine-config-operator
that referenced
this pull request
Apr 10, 2023
Enables the use of in-tree storage for vSphere. This feature flag was locked to true until recently. See kubernetes/kubernetes#116342 for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
As discussed in https://groups.google.com/g/kubernetes-sig-storage/c/wvJpNDBS9vU, we are going to unlock the CSIMigrationvSphere feature gate until there is a vSphere CSI driver version available that can provide feature parity with GA support.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: