Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #116145: Plumb stale GroupVersions through aggregated discovery #115865: Removes old discovery hack ignoring 403 and 404 #116437

Merged
merged 2 commits into from Mar 10, 2023
Merged

Automated cherry pick of #116145: Plumb stale GroupVersions through aggregated discovery #115865: Removes old discovery hack ignoring 403 and 404 #116437

merged 2 commits into from Mar 10, 2023

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Mar 9, 2023 •
edited

Cherry pick of #116145 #115865 on release-1.26.

#116145: Surface "stale" GroupVersions from AggregatedDiscovery
#115865: Updates old 403 and 404 discovery response tolerations

/kind feature

For details on the cherry pick process, see the cherry pick requests page.

NONE

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 9, 2023
@liggitt
Copy link
Member

liggitt commented Mar 9, 2023

I can see a case for backport of #115865

Isn't #116145 an alpha feature in 1.26? Is this fixing a bug impacting non-gated code?

@seans3
Copy link
Contributor Author

seans3 commented Mar 9, 2023 •
edited

@deads2k has asked for the "stale" feature to be backported to 1.26, completing the aggregated discovery client. And I had to cherry-pick both PR's to backport the "stale" PR. Also, there is a bug we discovered in the aggregated discovery client for an edge case which was fixed in the "stale" PR. This bug could surface if a v1.26 client was used against a v1.27 or later api server. BTW, the feature gate for aggregated discovery is only server-side.

@seans3
Copy link
Contributor Author

seans3 commented Mar 9, 2023

Unrelated unit test failure:

/retest

@seans3
Copy link
Contributor Author

seans3 commented Mar 9, 2023

/cc @deads2k
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 9, 2023
@seans3
Copy link
Contributor Author

seans3 commented Mar 9, 2023

/cc @Jefftree

@liggitt
Copy link
Member

liggitt commented Mar 10, 2023

@deads2k has asked for the "stale" feature to be backported to 1.26, completing the aggregated discovery client.

ah, ok. I'll let deadsk ack this since he approved the master PR

@liggitt liggitt removed their request for review March 10, 2023 13:43
@deads2k
Copy link
Contributor

deads2k commented Mar 10, 2023

Thanks.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b82de45b98c3a752bd1e1f45fcdd9aec48bd7cf7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@deads2k deads2k mentioned this pull request Mar 10, 2023
Merged
@Jefftree Jefftree mentioned this pull request Mar 10, 2023
Merged
@seans3
Copy link
Contributor Author

seans3 commented Mar 10, 2023

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team March 10, 2023 17:21
@seans3
Copy link
Contributor Author

seans3 commented Mar 10, 2023

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 10, 2023
@Verolop
Copy link

Verolop commented Mar 10, 2023

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 052842a into kubernetes:release-1.26 Mar 10, 2023
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@deads2k deads2k Awaiting requested review from deads2k

@Jefftree Jefftree Awaiting requested review from Jefftree

Assignees

@Verolop Verolop

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@seans3 @liggitt @deads2k @k8s-ci-robot @Verolop @fedebongio